[llvm] [AMDGPU] Remove magic constants from V_PK_ADD_F32 pattern. NFC (PR #164335)
    Stanislav Mekhanoshin via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Oct 20 23:04:38 PDT 2025
    
    
  
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/164335
>From 76e2467bc943449f1a38197fd7480d100ea8229d Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
Date: Mon, 20 Oct 2025 16:14:17 -0700
Subject: [PATCH] [AMDGPU] Remove magic constants from V_PK_ADD_F32 pattern.
 NFC
Ideally it shall be !or, but that is logical and not binary I believe.
---
 llvm/lib/Target/AMDGPU/SIInstructions.td | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index 74d41532170a6..6f1feb1dc2996 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -2223,8 +2223,8 @@ def : GCNPat <
 
 def : GCNPat <
   (DivergentUnaryFrag<fneg> (v2f32 VReg_64:$src)),
-  (V_PK_ADD_F32 11 /* OP_SEL_1 | NEG_LO | HEG_HI */, VReg_64:$src,
-                11 /* OP_SEL_1 | NEG_LO | HEG_HI */, (i64 0),
+  (V_PK_ADD_F32 !or(SRCMODS.OP_SEL_1, SRCMODS.NEG, SRCMODS.NEG_HI), VReg_64:$src,
+                !or(SRCMODS.OP_SEL_1, SRCMODS.NEG, SRCMODS.NEG_HI), (i64 0),
                 0, 0, 0, 0, 0)
 > {
   let SubtargetPredicate = HasPackedFP32Ops;
    
    
More information about the llvm-commits
mailing list