[compiler-rt] [llvm] [ASan] Do not instrument catch block parameters on Windows (PR #159618)

[Martin Storsjö via llvm-commits]

mstorsjo wrote:

Thanks for the prompt fix!

Btw, as a small side note - while it's good with backreferences to who reported what, having an `@username` reference in github commits causes a lot of spam when the commits get pushed to other downstream repos - see https://discourse.llvm.org/t/forbidding-username-in-commits/86997 for discussion on that.



> Question: does the LLVM CI not use mingw (or clang's libc)? , I'm just trying to understand why this didn't get caught in the PR CI. I could use some guidance understanding that better, to avoid this in the future.

The LLVM premerge CI only tests 2 configurations, a plain linux and plain windows configuration. I'm not even sure if compiler-rt tests are ran in that config at all, or if they are ran in both configurations. (If you did hit CI errors in earlier incarnations of the patch - we'd know that it does get ran in some form at least :-) )

As LLVM supports targeting many dozens of different targets (both architectures, OSes and environments within those OSes), we don't have test coverage for all of them in the premerge CI (which needs to be quick) - most of the other targets are covered in various buildbots. For mingw, I don't have any HW of my own (as an individual volunteer contributor) that I could set up for such a buildbot, but I run nightly test runs on github actions, where I catch some breakage later on at least.

But if it is relevant to test things more widely, it's somewhat easy to do through github actions. See https://github.com/mstorsjo/llvm-project/commit/gha-mingw-compiler-rt - there I have a commit which adds an extra test job, which gets executed on push to a branch (it doesn't even need to be part of an opened PR, you can just push it to a branch in your fork - although you may need to enable github actions for your fork). See https://github.com/mstorsjo/llvm-project/actions/runs/18630556946 for a recent test run. That runs tests for both i686, x86_64 and aarch64. Note that this configuration just uses the latest successful nightly llvm-mingw build, it doesn't test building a new compiler, so it might not work perfectly if the compiler-rt test changes require a matchingly updated compiler though. (Building a new compiler from scratch takes 2-3 hours, while this test in this form runs in ~10-15 minutes.)

https://github.com/llvm/llvm-project/pull/159618