[compiler-rt] [llvm] [ASan] Do not instrument catch block parameters on Windows (PR #159618)

[David Justo via llvm-commits]

davidmrdavid wrote:

Thanks for letting me know, @mstorsjo.

I see from your link the following note:
> The Microsoft implementation includes non-standard constructors taking strings thus allowing instances to be thrown directly with a meaningful error message. The nearest standard equivalents are [std::runtime_error](https://en.cppreference.com/w/cpp/error/runtime_error.html) or [std::logic_error](https://en.cppreference.com/w/cpp/error/logic_error.html).

_from:_ https://en.cppreference.com/w/cpp/error/exception/exception.html

I must have been implicitly relying on that behavior, as I was working on an "x64 Visual Studio native tools" shell for my testing. My apologies.

I wonder, does the LLVM CI not use mingw, I wonder why this didn't get caught in the PR CI. I could use some guidance understanding that better.

Anyways, on Monday morning (traveling at the moment) I can submit a PR to remediate the situation. Either by relying on `std::runtime_error`, or simply by removing the runtime test, which should be unnecessary given the `.ll` test.

https://github.com/llvm/llvm-project/pull/159618