[llvm] 4b1d782 - [X86] addConstantComments - merge (V)PMADDUBSW handling with all other mul opcode (#163963)

[via llvm-commits]

Author: Simon Pilgrim
Date: 2025-10-17T15:28:53+01:00
New Revision: 4b1d7827c07381610ad4fa7bd9d1a9659008b963

URL: https://github.com/llvm/llvm-project/commit/4b1d7827c07381610ad4fa7bd9d1a9659008b963
DIFF: https://github.com/llvm/llvm-project/commit/4b1d7827c07381610ad4fa7bd9d1a9659008b963.diff

LOG: [X86] addConstantComments - merge (V)PMADDUBSW handling with all other mul opcode (#163963)

These now all use the same asm printout code

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86MCInstLower.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp
index d454ca2e18be9..713d504474f5e 100644
--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -1954,21 +1954,7 @@ static void addConstantComments(const MachineInstr *MI,
   INSTR_CASE(V, Instr, Z, kz)
 
     // TODO: Add additional instructions when useful.
-    CASE_ARITH_RM(PMADDUBSW) {
-      unsigned SrcIdx = getSrcIdx(MI, 1);
-      if (auto *C = X86::getConstantFromPool(*MI, SrcIdx + 1)) {
-        std::string Comment;
-        raw_string_ostream CS(Comment);
-        unsigned VectorWidth =
-            X86::getVectorRegisterWidth(MI->getDesc().operands()[0]);
-        CS << "[";
-        printConstant(C, VectorWidth, CS);
-        CS << "]";
-        OutStreamer.AddComment(CS.str());
-      }
-      break;
-    }
-
+    CASE_ARITH_RM(PMADDUBSW)
     CASE_ARITH_RM(PMADDWD)
     CASE_ARITH_RM(PMULDQ)
     CASE_ARITH_RM(PMULUDQ)