[lld] 477704e - [lld][MachO] Disable read-workers.s test eveywhere

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 17 03:47:46 PDT 2025


Author: David Spickett
Date: 2025-10-17T10:45:18Z
New Revision: 477704e0fcaf6d86b4883275882a3b281d92bf53

URL: https://github.com/llvm/llvm-project/commit/477704e0fcaf6d86b4883275882a3b281d92bf53
DIFF: https://github.com/llvm/llvm-project/commit/477704e0fcaf6d86b4883275882a3b281d92bf53.diff

LOG: [lld][MachO] Disable read-workers.s test eveywhere

The ASAN bot failed on my previous fix for builds without
threading support:
https://lab.llvm.org/buildbot/#/builders/24/builds/13751

However that build does have threading enabled, so I do
not think my change is the cause. I think the cause is
what #157917 will address:
> The new PR moves to use madvise() instead of the ad-hoc page referencing code I wrote which should avoid SIGSEGVs if the buffer is deallocated.

While that is being reviewed, do not run this test
anywhere. Though the failure I saw was with ASAN, I
think it could happen anywhere.

Added: 
    

Modified: 
    lld/test/MachO/read-workers.s

Removed: 
    


################################################################################
diff  --git a/lld/test/MachO/read-workers.s b/lld/test/MachO/read-workers.s
index 4d2f88c2a757c..294106ba0b084 100644
--- a/lld/test/MachO/read-workers.s
+++ b/lld/test/MachO/read-workers.s
@@ -1,4 +1,7 @@
 # REQUIRES: x86 && thread_support
+## Sometimes fails, particularly in an ASAN build, do not run until
+## https://github.com/llvm/llvm-project/pull/157917 addresses the cause.
+# UNSUPPORTED: target={{.*}}
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
 
 ## A non-negative integer is allowed.


        


More information about the llvm-commits mailing list