[llvm] [llvm-objdump] Fix --disassembler-color with --macho flag (PR #163815)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 17 00:13:26 PDT 2025


================
@@ -6,6 +6,10 @@
 // RUN: llvm-objdump --disassembler-color=off --disassemble %t | FileCheck %s --check-prefix=NOCOLOR
 // RUN: llvm-objdump --disassembler-color=terminal --disassemble %t | FileCheck %s --check-prefix=NOCOLOR
 
+// Test with --macho flag to ensure DisassembleMachO respects color settings
----------------
jh7370 wrote:

Nit 1: missing full stop at end of sentence.
Nit 2: newer llvm binutils tests usually use double comment markers for true comments like this to help contrast them with the lit and FileCheck directives.
```suggestion
//// Test with --macho flag to ensure DisassembleMachO respects color settings.
```

https://github.com/llvm/llvm-project/pull/163815


More information about the llvm-commits mailing list