[llvm] [OFFLOAD] Interop fixes for Windows (PR #162652)
Joseph Huber via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 16 10:56:37 PDT 2025
================
@@ -22,8 +22,7 @@ extern "C" {
void __kmpc_omp_wait_deps(ident_t *loc_ref, int32_t gtid, int32_t ndeps,
kmp_depend_info_t *dep_list, int32_t ndeps_noalias,
- kmp_depend_info_t *noalias_dep_list)
- __attribute__((weak));
----------------
jhuber6 wrote:
Okay, so weak extern symbols are defined as nullptr and not a linker error in ELF. This might be trying to prevent that? I don't really know for sure what it's trying to do. There's no check on this function so if it wasn't defined this code would segfault. I'm just going to assume it's not needed, since we should always link `liboimp w/ `libomptarget` anyways.
https://github.com/llvm/llvm-project/pull/162652
More information about the llvm-commits
mailing list