[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

[Vladislav Dzhidzhoev via llvm-commits]

dzhidzhoev wrote:

> I think it sounds roughly plausible - the perf issue I wouldn't /expect/ to be a problem, there's probably a lot more types (in a full debug info build at least) than functions (hmm, well, actually hard to say - guess it could go either way) & I guess it's well enough optimized it hopefully won't show up in profiles or the like.

I asked because, as I've discovered in the mailing list, performance was the initial reason to switch from uniqued DISubprograms to distinct ones.

> I will say, partly as I'm not as heavily involved in debug info anymore, and partly as this work is getting more involved - I'm losing my grasp on all the details, but doing my best to help - just fair warning that you're getting out into pretty unmarked territory & just going to take the adventure and see what happens...

Thank you! Your help is appreciated.



https://github.com/llvm/llvm-project/pull/142166