[llvm] [SystemZ] Fix variable names to reflect Coding Standards (PR #161899)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 9 04:48:23 PDT 2025
https://github.com/dvldogg updated https://github.com/llvm/llvm-project/pull/161899
>From 19227365fa337aca65b6f9bf44126e0d75c89047 Mon Sep 17 00:00:00 2001
From: Ismael Marisclan <Ismael.Marisclan at ibm.com>
Date: Fri, 3 Oct 2025 12:16:35 -0700
Subject: [PATCH 1/4] fix variable names to reflect standards
---
.../SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp | 6 +++---
llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp | 6 +++---
llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp b/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
index af79070db7b96..275165d2acb07 100644
--- a/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
+++ b/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
@@ -184,8 +184,8 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
// Output the TLS marker if present.
if ((unsigned)OpNum + 1 < MI->getNumOperands()) {
const MCOperand &MO = MI->getOperand(OpNum + 1);
- const MCSymbolRefExpr &refExp = cast<MCSymbolRefExpr>(*MO.getExpr());
- switch (refExp.getSpecifier()) {
+ const MCSymbolRefExpr &RefExp = cast<MCSymbolRefExpr>(*MO.getExpr());
+ switch (RefExp.getSpecifier()) {
case SystemZ::S_TLSGD:
O << ":tls_gdcall:";
break;
@@ -195,7 +195,7 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
default:
llvm_unreachable("Unexpected symbol kind");
}
- O << refExp.getSymbol().getName();
+ O << RefExp.getSymbol().getName();
}
}
diff --git a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
index fce6393969a2d..3a86680948eb1 100644
--- a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
@@ -14,9 +14,9 @@
using namespace llvm;
SystemZConstantPoolValue::
-SystemZConstantPoolValue(const GlobalValue *gv,
- SystemZCP::SystemZCPModifier modifier)
- : MachineConstantPoolValue(gv->getType()), GV(gv), Modifier(modifier) {}
+SystemZConstantPoolValue(const GlobalValue *GV,
+ SystemZCP::SystemZCPModifier Modifier)
+ : MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
SystemZConstantPoolValue *
SystemZConstantPoolValue::Create(const GlobalValue *GV,
diff --git a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
index 34d58e05ff3e4..af0913563e8b5 100644
--- a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
@@ -352,10 +352,10 @@ int SystemZHazardRecognizer::groupingCost(SUnit *SU) const {
// Similarly, a group-ending SU may either fit well (last in group), or
// end the group prematurely.
if (SC->EndGroup) {
- unsigned resultingGroupSize =
+ unsigned ResultingGroupSize =
(CurrGroupSize + getNumDecoderSlots(SU));
- if (resultingGroupSize < 3)
- return (3 - resultingGroupSize);
+ if (ResultingGroupSize < 3)
+ return (3 - ResultingGroupSize);
return -1;
}
>From fc48d356341f8e7cfd9a3d9fb3de02486b9c5f1c Mon Sep 17 00:00:00 2001
From: Ismael Marisclan <Ismael.Marisclan at ibm.com>
Date: Fri, 3 Oct 2025 12:16:35 -0700
Subject: [PATCH 2/4] fix variable names to reflect standards
---
.../SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp | 6 +++---
llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp | 6 +++---
llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp b/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
index af79070db7b96..275165d2acb07 100644
--- a/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
+++ b/llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinterCommon.cpp
@@ -184,8 +184,8 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
// Output the TLS marker if present.
if ((unsigned)OpNum + 1 < MI->getNumOperands()) {
const MCOperand &MO = MI->getOperand(OpNum + 1);
- const MCSymbolRefExpr &refExp = cast<MCSymbolRefExpr>(*MO.getExpr());
- switch (refExp.getSpecifier()) {
+ const MCSymbolRefExpr &RefExp = cast<MCSymbolRefExpr>(*MO.getExpr());
+ switch (RefExp.getSpecifier()) {
case SystemZ::S_TLSGD:
O << ":tls_gdcall:";
break;
@@ -195,7 +195,7 @@ void SystemZInstPrinterCommon::printPCRelTLSOperand(const MCInst *MI,
default:
llvm_unreachable("Unexpected symbol kind");
}
- O << refExp.getSymbol().getName();
+ O << RefExp.getSymbol().getName();
}
}
diff --git a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
index fce6393969a2d..3a86680948eb1 100644
--- a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
@@ -14,9 +14,9 @@
using namespace llvm;
SystemZConstantPoolValue::
-SystemZConstantPoolValue(const GlobalValue *gv,
- SystemZCP::SystemZCPModifier modifier)
- : MachineConstantPoolValue(gv->getType()), GV(gv), Modifier(modifier) {}
+SystemZConstantPoolValue(const GlobalValue *GV,
+ SystemZCP::SystemZCPModifier Modifier)
+ : MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
SystemZConstantPoolValue *
SystemZConstantPoolValue::Create(const GlobalValue *GV,
diff --git a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
index 34d58e05ff3e4..af0913563e8b5 100644
--- a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
@@ -352,10 +352,10 @@ int SystemZHazardRecognizer::groupingCost(SUnit *SU) const {
// Similarly, a group-ending SU may either fit well (last in group), or
// end the group prematurely.
if (SC->EndGroup) {
- unsigned resultingGroupSize =
+ unsigned ResultingGroupSize =
(CurrGroupSize + getNumDecoderSlots(SU));
- if (resultingGroupSize < 3)
- return (3 - resultingGroupSize);
+ if (ResultingGroupSize < 3)
+ return (3 - ResultingGroupSize);
return -1;
}
>From 9d30d62578e35070561c66b49ad85cadf63f474f Mon Sep 17 00:00:00 2001
From: Ismael Marisclan <Ismael.Marisclan at ibm.com>
Date: Wed, 8 Oct 2025 11:36:22 -0700
Subject: [PATCH 3/4] fix issues pointed out by failing check
---
llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp | 5 ++---
llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp | 3 +--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
index 3a86680948eb1..8c4b299ec462f 100644
--- a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
@@ -13,9 +13,8 @@
using namespace llvm;
-SystemZConstantPoolValue::
-SystemZConstantPoolValue(const GlobalValue *GV,
- SystemZCP::SystemZCPModifier Modifier)
+SystemZConstantPoolValue::SystemZConstantPoolValue(
+ const GlobalValue *GV, SystemZCP::SystemZCPModifier Modifier)
: MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
SystemZConstantPoolValue *
diff --git a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
index af0913563e8b5..5313fba3bed1d 100644
--- a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
@@ -352,8 +352,7 @@ int SystemZHazardRecognizer::groupingCost(SUnit *SU) const {
// Similarly, a group-ending SU may either fit well (last in group), or
// end the group prematurely.
if (SC->EndGroup) {
- unsigned ResultingGroupSize =
- (CurrGroupSize + getNumDecoderSlots(SU));
+ unsigned ResultingGroupSize = (CurrGroupSize + getNumDecoderSlots(SU));
if (ResultingGroupSize < 3)
return (3 - ResultingGroupSize);
return -1;
>From 8350d95579dd4a23f639e4faa6fbf5b107c1e180 Mon Sep 17 00:00:00 2001
From: Ismael Marisclan <Ismael.Marisclan at ibm.com>
Date: Thu, 9 Oct 2025 04:47:54 -0700
Subject: [PATCH 4/4] indent fix
---
llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
index 8c4b299ec462f..8c31579b4f799 100644
--- a/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZConstantPoolValue.cpp
@@ -14,8 +14,8 @@
using namespace llvm;
SystemZConstantPoolValue::SystemZConstantPoolValue(
- const GlobalValue *GV, SystemZCP::SystemZCPModifier Modifier)
- : MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
+ const GlobalValue *GV, SystemZCP::SystemZCPModifier Modifier)
+ : MachineConstantPoolValue(GV->getType()), GV(GV), Modifier(Modifier) {}
SystemZConstantPoolValue *
SystemZConstantPoolValue::Create(const GlobalValue *GV,
More information about the llvm-commits
mailing list