[llvm] c083fa1 - [NFC][SpecialCaseList] Use BumpPtrAllocator to own strings (#162304)

[via llvm-commits]

Author: Vitaly Buka
Date: 2025-10-08T22:56:38Z
New Revision: c083fa1597f1a34fcab4c2910158a288defc72f6

URL: https://github.com/llvm/llvm-project/commit/c083fa1597f1a34fcab4c2910158a288defc72f6
DIFF: https://github.com/llvm/llvm-project/commit/c083fa1597f1a34fcab4c2910158a288defc72f6.diff

LOG: [NFC][SpecialCaseList] Use BumpPtrAllocator to own strings (#162304)

This simplifies structure of GlobMatcher, and
avoids "no copy/move" requirement.

Added: 
    

Modified: 
    llvm/include/llvm/Support/SpecialCaseList.h
    llvm/lib/Support/SpecialCaseList.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index 27daa1f4c6116..466e2a40c9093 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -14,6 +14,7 @@
 
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/StringMap.h"
+#include "llvm/Support/Allocator.h"
 #include "llvm/Support/Compiler.h"
 #include "llvm/Support/GlobPattern.h"
 #include "llvm/Support/Regex.h"
@@ -132,14 +133,12 @@ class SpecialCaseList {
     struct Reg {
       Reg(StringRef Name, unsigned LineNo, Regex &&Rg)
           : Name(Name), LineNo(LineNo), Rg(std::move(Rg)) {}
-      std::string Name;
+      StringRef Name;
       unsigned LineNo;
       Regex Rg;
-      Reg(Reg &&) = delete;
-      Reg() = default;
     };
 
-    std::vector<std::unique_ptr<Reg>> RegExes;
+    std::vector<Reg> RegExes;
   };
 
   class GlobMatcher {
@@ -150,17 +149,14 @@ class SpecialCaseList {
           llvm::function_ref<void(StringRef Rule, unsigned LineNo)> Cb) const;
 
     struct Glob {
-      Glob(StringRef Name, unsigned LineNo) : Name(Name), LineNo(LineNo) {}
-      std::string Name;
+      Glob(StringRef Name, unsigned LineNo, GlobPattern &&Pattern)
+          : Name(Name), LineNo(LineNo), Pattern(std::move(Pattern)) {}
+      StringRef Name;
       unsigned LineNo;
       GlobPattern Pattern;
-      // neither copyable nor movable because GlobPattern contains
-      // Glob::StringRef that points to Glob::Name.
-      Glob(Glob &&) = delete;
-      Glob() = default;
     };
 
-    std::vector<std::unique_ptr<Glob>> Globs;
+    std::vector<GlobMatcher::Glob> Globs;
   };
 
   /// Represents a set of patterns and their line numbers
@@ -217,6 +213,7 @@ class SpecialCaseList {
   ArrayRef<const Section> sections() const { return Sections; }
 
 private:
+  BumpPtrAllocator StrAlloc;
   std::vector<Section> Sections;
 
   LLVM_ABI Expected<Section *> addSection(StringRef SectionStr,

diff  --git a/llvm/lib/Support/SpecialCaseList.cpp b/llvm/lib/Support/SpecialCaseList.cpp
index 8ec6b1d46aeff..80fd48558fe67 100644
--- a/llvm/lib/Support/SpecialCaseList.cpp
+++ b/llvm/lib/Support/SpecialCaseList.cpp
@@ -51,18 +51,16 @@ Error SpecialCaseList::RegexMatcher::insert(StringRef Pattern,
   if (!CheckRE.isValid(REError))
     return createStringError(errc::invalid_argument, REError);
 
-  auto Rg = std::make_unique<Reg>(Pattern, LineNumber, std::move(CheckRE));
-  RegExes.emplace_back(std::move(Rg));
-
+  RegExes.emplace_back(Pattern, LineNumber, std::move(CheckRE));
   return Error::success();
 }
 
 void SpecialCaseList::RegexMatcher::match(
     StringRef Query,
     llvm::function_ref<void(StringRef Rule, unsigned LineNo)> Cb) const {
-  for (const auto &Regex : reverse(RegExes))
-    if (Regex->Rg.match(Query))
-      Cb(Regex->Name, Regex->LineNo);
+  for (const auto &R : reverse(RegExes))
+    if (R.Rg.match(Query))
+      Cb(R.Name, R.LineNo);
 }
 
 Error SpecialCaseList::GlobMatcher::insert(StringRef Pattern,
@@ -70,22 +68,19 @@ Error SpecialCaseList::GlobMatcher::insert(StringRef Pattern,
   if (Pattern.empty())
     return createStringError(errc::invalid_argument, "Supplied glob was blank");
 
-  auto G = std::make_unique<Glob>(Pattern, LineNumber);
-  // We must be sure to use the string in `Glob` rather than the provided
-  // reference which could be destroyed before match() is called
-  if (auto Err = GlobPattern::create(G->Name, /*MaxSubPatterns=*/1024)
-                     .moveInto(G->Pattern))
+  auto Res = GlobPattern::create(Pattern, /*MaxSubPatterns=*/1024);
+  if (auto Err = Res.takeError())
     return Err;
-  Globs.emplace_back(std::move(G));
+  Globs.emplace_back(Pattern, LineNumber, std::move(Res.get()));
   return Error::success();
 }
 
 void SpecialCaseList::GlobMatcher::match(
     StringRef Query,
     llvm::function_ref<void(StringRef Rule, unsigned LineNo)> Cb) const {
-  for (const auto &Glob : reverse(Globs))
-    if (Glob->Pattern.match(Query))
-      Cb(Glob->Name, Glob->LineNo);
+  for (const auto &G : reverse(Globs))
+    if (G.Pattern.match(Query))
+      Cb(G.Name, G.LineNo);
 }
 
 SpecialCaseList::Matcher::Matcher(bool UseGlobs, bool RemoveDotSlash)
@@ -167,6 +162,7 @@ SpecialCaseList::addSection(StringRef SectionStr, unsigned FileNo,
   Sections.emplace_back(SectionStr, FileNo, UseGlobs);
   auto &Section = Sections.back();
 
+  SectionStr = SectionStr.copy(StrAlloc);
   if (auto Err = Section.SectionMatcher.insert(SectionStr, LineNo)) {
     return createStringError(errc::invalid_argument,
                              "malformed section at line " + Twine(LineNo) +
@@ -241,6 +237,7 @@ bool SpecialCaseList::parse(unsigned FileIdx, const MemoryBuffer *MB,
     auto [It, _] = CurrentSection->Entries[Prefix].try_emplace(
         Category, UseGlobs,
         RemoveDotSlash && llvm::is_contained(PathPrefixes, Prefix));
+    Pattern = Pattern.copy(StrAlloc);
     if (auto Err = It->second.insert(Pattern, LineNo)) {
       Error =
           (Twine("malformed ") + (UseGlobs ? "glob" : "regex") + " in line " +