[llvm] [AMDGPU] Do not put memory instructions in *ALU SchedGroups (PR #162560)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 8 15:28:55 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp b/llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
index a161c21f6..3913bfbe3 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
@@ -2400,7 +2400,7 @@ bool SchedGroup::canAddMI(const MachineInstr &MI) const {
TII->isVALU(MI) && !TII->isMFMAorWMMA(MI) && !TII->isTRANS(MI))
// Some memory instructions may be marked as VALU (e.g. BUFFER_LOAD_*_LDS).
// For our purposes, these shall not be classified as VALU as this results
- // in unexpected behavior.
+ // in unexpected behavior.
Result = !(MI.mayLoad() || MI.mayLoad());
else if (((SGMask & SchedGroupMask::SALU) != SchedGroupMask::NONE) &&
``````````
</details>
https://github.com/llvm/llvm-project/pull/162560
More information about the llvm-commits
mailing list