[llvm] github-automation.py: Fix mis-indented statement (PR #149653)

Kleis Auke Wolthuizen via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 8 07:49:32 PDT 2025


================
@@ -654,7 +654,7 @@ def pr_request_review(self, pr: github.PullRequest.PullRequest):
                 for review in pull.get_reviews():
                     if review.state != "APPROVED":
----------------
kleisauke wrote:

FWIW, we might also want to check the author associations as a possible follow-up. For example:
```suggestion
                    if review.state != "APPROVED" or review.author_association not in ("COLLABORATOR", "CONTRIBUTOR", "MANNEQUIN", "MEMBER", "OWNER"):
``` 
(untested)

This would align with what the PR greeter script does:
https://github.com/llvm/llvm-project/blob/ecadd9073ac161a3c0ca77c62065098b1bf6461c/.github/workflows/new-prs.yml#L31-L35

That way, users who don't have sufficient permissions to land a PR (but have left a review on the original PR) wouldn't be notified and added as reviewers on backport PRs.


https://github.com/llvm/llvm-project/pull/149653


More information about the llvm-commits mailing list