[llvm] [LLVM-C] Upstream `LLVMBuildAtomicLoad/Store` from rustc (PR #162450)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 8 03:46:38 PDT 2025
AMS21 wrote:
> Hm, do we really need these? Aren't these just combinations of LLVMBuildLoad2/LLVMBuildStore + LLVMSetOrdering (+ LLVMSetAtomicSingleThread if necessary)?
>
> The calling code already sets the alignment separately: https://github.com/rust-lang/rust/blob/5767910cbcc9d199bf261a468574d45aa3857599/compiler/rustc_codegen_llvm/src/builder.rs#L649-L650 So I don't think there is a strong reason to integrate setting the ordering into one C API call.
Alright I guess then it would be better to refactor this on the rustc side.
Thanks for the quick response :)
https://github.com/llvm/llvm-project/pull/162450
More information about the llvm-commits
mailing list