[llvm] d09d63a - [Offload] Let binary utility take empty arguments (#162317)

[via llvm-commits]

Author: Joseph Huber
Date: 2025-10-07T12:51:00-05:00
New Revision: d09d63a7d53a0cda602944c5336ad8b8c10cd687

URL: https://github.com/llvm/llvm-project/commit/d09d63a7d53a0cda602944c5336ad8b8c10cd687
DIFF: https://github.com/llvm/llvm-project/commit/d09d63a7d53a0cda602944c5336ad8b8c10cd687.diff

LOG: [Offload] Let binary utility take empty arguments (#162317)

Summary:
There's no real reason to restrict people if they don't want to use
`triple`. It's important for the normal pipeline but I can see people
using these for other purposes.

Added: 
    

Modified: 
    llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll
    llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll b/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll
index b196c24b0f6f1..c6027b360e5cc 100644
--- a/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll
+++ b/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll
@@ -8,3 +8,7 @@
 ; CHECK-NEXT: arch            abc
 ; CHECK-NEXT: triple          x-y-z
 ; CHECK-NEXT: producer        none
+
+; RUN: llvm-offload-binary -o %t3 --image=file=%s
+; RUN: llvm-offload-binary %t3 --image=file=%t4
+; RUN: 
diff  %s %t4

diff  --git a/llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp b/llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp
index b1bc335fe5b9e..e22d13b946651 100644
--- a/llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp
+++ b/llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp
@@ -92,10 +92,9 @@ static Error bundleImages() {
     StringSaver Saver(Alloc);
     DenseMap<StringRef, StringRef> Args = getImageArguments(Image, Saver);
 
-    if (!Args.count("triple") || !Args.count("file"))
-      return createStringError(
-          inconvertibleErrorCode(),
-          "'file' and 'triple' are required image arguments");
+    if (!Args.count("file"))
+      return createStringError(inconvertibleErrorCode(),
+                               "'file' is a required image arguments");
 
     // Permit using multiple instances of `file` in a single string.
     for (auto &File : llvm::split(Args["file"], ",")) {