[llvm] [DirectX] Remove custom error classes from RootSignature Metadata parser (PR #161921)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 6 14:41:09 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- llvm/include/llvm/Frontend/HLSL/RootSignatureMetadata.h llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp b/llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp
index 73d91a47c..3bf2b8113 100644
--- a/llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp
+++ b/llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp
@@ -823,10 +823,10 @@ Error MetadataParser::validateRootSignature(
                                               Sampler.ShaderRegister));
 
     if (!hlsl::rootsig::verifyRegisterSpace(Sampler.RegisterSpace))
-      DeferredErrs =
-          joinErrors(std::move(DeferredErrs),
-                     createRSError(RSErrorKind::Validation, StringRef(
-                         "RegisterSpace"), Sampler.RegisterSpace));
+      DeferredErrs = joinErrors(std::move(DeferredErrs),
+                                createRSError(RSErrorKind::Validation,
+                                              StringRef("RegisterSpace"),
+                                              Sampler.RegisterSpace));
     bool IsValidFlag =
         dxbc::isValidStaticSamplerFlags(Sampler.Flags) &&
         hlsl::rootsig::verifyStaticSamplerFlags(

``````````

</details>


https://github.com/llvm/llvm-project/pull/161921


More information about the llvm-commits mailing list