[llvm] 27c207e - [NFC][SPIRV] GetElementPtrInst does not need a call to isInstructionTriviallyDead after replaceUsesofWith (#162045)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 6 09:13:35 PDT 2025


Author: Juan Manuel Martinez CaamaƱo
Date: 2025-10-06T18:13:31+02:00
New Revision: 27c207ef4c7ec11757c26ae11e3aa45cdb4dc90f

URL: https://github.com/llvm/llvm-project/commit/27c207ef4c7ec11757c26ae11e3aa45cdb4dc90f
DIFF: https://github.com/llvm/llvm-project/commit/27c207ef4c7ec11757c26ae11e3aa45cdb4dc90f.diff

LOG: [NFC][SPIRV] GetElementPtrInst does not need a call to isInstructionTriviallyDead after replaceUsesofWith (#162045)

A getelementptr is always removable after replacing all its uses, since
it doesn't have side effects and always returns.

Added: 
    

Modified: 
    llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
index 9f2e07508a36a..e16c8f0fc302e 100644
--- a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
@@ -2811,9 +2811,7 @@ bool SPIRVEmitIntrinsics::runOnFunction(Function &Func) {
     GetElementPtrInst *NewGEP = simplifyZeroLengthArrayGepInst(Ref);
     if (NewGEP) {
       Ref->replaceAllUsesWith(NewGEP);
-      if (isInstructionTriviallyDead(Ref))
-        DeadInsts.insert(Ref);
-
+      DeadInsts.insert(Ref);
       Ref = NewGEP;
     }
     if (Type *GepTy = getGEPType(Ref))


        


More information about the llvm-commits mailing list