[llvm] [NFC] Fix memory leak in IR2Vec tests (PR #161964)

via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 4 11:37:31 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-analysis

Author: Jinsong Ji (jsji)

<details>
<summary>Changes</summary>

After refactoring in ed1d9548b5c0, VocabStorage are being leaked.


---
Full diff: https://github.com/llvm/llvm-project/pull/161964.diff


2 Files Affected:

- (modified) llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp (+5) 
- (modified) llvm/unittests/Analysis/IR2VecTest.cpp (+4) 


``````````diff
diff --git a/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp b/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp
index 497da8f3fc70b..ec1e848f943be 100644
--- a/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp
+++ b/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp
@@ -59,6 +59,11 @@ class FunctionPropertiesAnalysisTest : public testing::Test {
     ir2vec::ArgWeight = 1.0;
   }
 
+  ~FunctionPropertiesAnalysisTest() override {
+    delete IR2VecVocab;
+    IR2VecVocab = nullptr;
+  }
+
 private:
   float OriginalOpcWeight = ir2vec::OpcWeight;
   float OriginalTypeWeight = ir2vec::TypeWeight;
diff --git a/llvm/unittests/Analysis/IR2VecTest.cpp b/llvm/unittests/Analysis/IR2VecTest.cpp
index d136cb6a316b1..4348d5cee106a 100644
--- a/llvm/unittests/Analysis/IR2VecTest.cpp
+++ b/llvm/unittests/Analysis/IR2VecTest.cpp
@@ -319,6 +319,10 @@ class IR2VecTestFixture : public ::testing::Test {
     AddInst = BinaryOperator::CreateAdd(Arg, Const, "add", BB);
     RetInst = ReturnInst::Create(Ctx, AddInst, BB);
   }
+  void TearDown() override {
+    delete V ;
+    V = nullptr;
+  }
 };
 
 TEST_F(IR2VecTestFixture, GetInstVecMap_Symbolic) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/161964


More information about the llvm-commits mailing list