[llvm] 679d2b2 - AMDGPU: Fix using IRAttribute with nounwind for AMDGPUNoAGPR (#161954)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 4 07:45:20 PDT 2025
Author: Matt Arsenault
Date: 2025-10-04T23:45:16+09:00
New Revision: 679d2b2ab618a1933c5feb216d665b703d80a650
URL: https://github.com/llvm/llvm-project/commit/679d2b2ab618a1933c5feb216d665b703d80a650
DIFF: https://github.com/llvm/llvm-project/commit/679d2b2ab618a1933c5feb216d665b703d80a650.diff
LOG: AMDGPU: Fix using IRAttribute with nounwind for AMDGPUNoAGPR (#161954)
Don't think this did anything harmful, but it doesn't make sense
to report this as implementing nounwind handling.
Added:
Modified:
llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp b/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
index 9dd64e0f6b35b..cb49936871e74 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
@@ -1224,12 +1224,9 @@ static bool inlineAsmUsesAGPRs(const InlineAsm *IA) {
}
// TODO: Migrate to range merge of amdgpu-agpr-alloc.
-// FIXME: Why is this using Attribute::NoUnwind?
-struct AAAMDGPUNoAGPR
- : public IRAttribute<Attribute::NoUnwind,
- StateWrapper<BooleanState, AbstractAttribute>,
- AAAMDGPUNoAGPR> {
- AAAMDGPUNoAGPR(const IRPosition &IRP, Attributor &A) : IRAttribute(IRP) {}
+struct AAAMDGPUNoAGPR : public StateWrapper<BooleanState, AbstractAttribute> {
+ using Base = StateWrapper<BooleanState, AbstractAttribute>;
+ AAAMDGPUNoAGPR(const IRPosition &IRP, Attributor &A) : Base(IRP) {}
static AAAMDGPUNoAGPR &createForPosition(const IRPosition &IRP,
Attributor &A) {
More information about the llvm-commits
mailing list