[llvm] [MachO] Move getArchTriple implementation into BinaryFormat. (PR #161468)

Sat Oct 4 01:53:29 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-ubuntu` running on `as-builder-7` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/26055

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/include/llvm/ProfileData/SampleProf.h: In instantiation of ‘llvm::sampleprof_error llvm::sampleprof::FunctionSamples::addCallsiteVTableTypeProfAt(const llvm::sampleprof::LineLocation&, const T&, uint64_t) [with T = llvm::DenseMap<llvm::StringRef, long unsigned int>; uint64_t = long unsigned int]’:
/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/lib/ProfileData/SampleProfReader.cpp:465:68:   required from here
/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/include/llvm/ProfileData/SampleProf.h:1075:21: warning: loop variable ‘<structured bindings>’ creates a copy from type ‘const llvm::detail::DenseMapPair<llvm::StringRef, long unsigned int>’ [-Wrange-loop-construct]
 1075 |     for (const auto [Type, Count] : Other) {
      |                     ^~~~~~~~~~~~~
/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/llvm-project/llvm/include/llvm/ProfileData/SampleProf.h:1075:21: note: use reference type to prevent copying
 1075 |     for (const auto [Type, Count] : Other) {
      |                     ^~~~~~~~~~~~~
      |                     &
47.535 [659/10/2162] Linking CXX shared library lib/libLLVMCoverage.so.22.0git
FAILED: lib/libLLVMCoverage.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=gold   -Wl,--gc-sections -shared -Wl,-soname,libLLVMCoverage.so.22.0git -o lib/libLLVMCoverage.so.22.0git lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMapping.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingWriter.cpp.o lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/lib:"  lib/libLLVMProfileData.so.22.0git  lib/libLLVMObject.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMTargetParser.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/buildbot/worker/as-builder-7/llvm-nvptx64-nvidia-ubuntu/build/lib && :
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o:CoverageMappingReader.cpp:function llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x1de): error: undefined reference to 'llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o:CoverageMappingReader.cpp:function llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x5ca): error: undefined reference to 'llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o:CoverageMappingReader.cpp:function llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x717): error: undefined reference to 'llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
lib/ProfileData/Coverage/CMakeFiles/LLVMCoverage.dir/CoverageMappingReader.cpp.o:CoverageMappingReader.cpp:function llvm::coverage::BinaryCoverageReader::create(llvm::MemoryBufferRef, llvm::StringRef, llvm::SmallVectorImpl<std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer> > >&, llvm::StringRef, llvm::SmallVectorImpl<llvm::ArrayRef<unsigned char> >*) [clone .localalias]:(.text._ZN4llvm8coverage20BinaryCoverageReader6createENS_15MemoryBufferRefENS_9StringRefERNS_15SmallVectorImplISt10unique_ptrINS_12MemoryBufferESt14default_deleteIS6_EEEES3_PNS4_INS_8ArrayRefIhEEEE+0x897): error: undefined reference to 'llvm::MachO::getArchTriple(unsigned int, unsigned int, char const**, char const**)'
collect2: error: ld returned 1 exit status
50.171 [659/4/2168] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/AddressSanitizer.cpp.o
54.195 [659/2/2170] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
58.598 [659/1/2171] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/161468