[llvm] [InstCombine] Preserve profile after folding select instructions with conditionals (PR #159666)

Fri Oct 3 10:29:55 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `hip-third-party-libs-test` running on `ext_buildbot_hw_05-hip-docker` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/206/builds/7045

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/hip-tpl.py --jobs=32' (failure)
...
[5343/8096] Linking CXX shared library lib/libMLIRArmSMETransforms.so.22.0git
[5344/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.8.cpp.o
[5345/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.9.cpp.o
[5346/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.5.cpp.o
[5347/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.10.cpp.o
[5348/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.11.cpp.o
[5349/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.12.cpp.o
[5350/8096] Creating library symlink lib/libMLIRArmSMETransforms.so
[5351/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5352/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/hip-third-party-libs-test/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2eb): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5353/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.14.cpp.o
[5354/8096] Creating library symlink lib/libLLVMInstrumentation.so
[5355/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.15.cpp.o
[5356/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.16.cpp.o
[5357/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.13.cpp.o
[5358/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.19.cpp.o
[5359/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.18.cpp.o
[5360/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.17.cpp.o
[5361/8096] Linking CXX shared library lib/libMLIRVectorToSCF.so.22.0git
[5362/8096] Linking CXX shared library lib/libMLIRXeGPUToXeVM.so.22.0git
[5363/8096] Linking CXX shared library lib/libMLIRTensorTestPasses.so.22.0git
[5364/8096] Linking CXX shared library lib/libMLIRVectorToXeGPU.so.22.0git
[5365/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5366/8096] Linking CXX shared library lib/libMLIRVectorToGPU.so.22.0git
[5367/8096] Linking CXX shared library lib/libMLIRAsyncTransforms.so.22.0git
[5368/8096] Linking CXX shared library lib/libMLIRXeGPUTransforms.so.22.0git
[5369/8096] Linking CXX shared library lib/libMLIRSPIRVConversion.so.22.0git
[5370/8096] Linking CXX shared library lib/libMLIRSCFTransformOps.so.22.0git
[5371/8096] Linking CXX shared library lib/libMLIRMemRefTransformOps.so.22.0git
[5372/8096] Building AMDGPUGenSubtargetInfo.inc...
[5373/8096] Building AMDGPUGenDisassemblerTables.inc...
[5374/8096] Linking CXX shared library lib/libMLIRArmSMEToLLVM.so.22.0git
[5375/8096] Building AMDGPUGenSearchableTables.inc...
[5376/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5377/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5378/8096] Building AMDGPUGenCallingConv.inc...
[5379/8096] Building AMDGPUGenAsmWriter.inc...
[5380/8096] Building AMDGPUGenGlobalISel.inc...
[5381/8096] Building AMDGPUGenDAGISel.inc...
[5382/8096] Building AMDGPUGenInstrInfo.inc...
[5383/8096] Building AMDGPUGenAsmMatcher.inc...
[5384/8096] Building AMDGPUGenRegisterInfo.inc...
[5385/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5343/8096] Linking CXX shared library lib/libMLIRArmSMETransforms.so.22.0git
[5344/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.8.cpp.o
[5345/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.9.cpp.o
[5346/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.5.cpp.o
[5347/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.10.cpp.o
[5348/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.11.cpp.o
[5349/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.12.cpp.o
[5350/8096] Creating library symlink lib/libMLIRArmSMETransforms.so
[5351/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5352/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/hip-third-party-libs-test/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/hip-third-party-libs-test/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2eb): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5353/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.14.cpp.o
[5354/8096] Creating library symlink lib/libLLVMInstrumentation.so
[5355/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.15.cpp.o
[5356/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.16.cpp.o
[5357/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.13.cpp.o
[5358/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.19.cpp.o
[5359/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.18.cpp.o
[5360/8096] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.17.cpp.o
[5361/8096] Linking CXX shared library lib/libMLIRVectorToSCF.so.22.0git
[5362/8096] Linking CXX shared library lib/libMLIRXeGPUToXeVM.so.22.0git
[5363/8096] Linking CXX shared library lib/libMLIRTensorTestPasses.so.22.0git
[5364/8096] Linking CXX shared library lib/libMLIRVectorToXeGPU.so.22.0git
[5365/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5366/8096] Linking CXX shared library lib/libMLIRVectorToGPU.so.22.0git
[5367/8096] Linking CXX shared library lib/libMLIRAsyncTransforms.so.22.0git
[5368/8096] Linking CXX shared library lib/libMLIRXeGPUTransforms.so.22.0git
[5369/8096] Linking CXX shared library lib/libMLIRSPIRVConversion.so.22.0git
[5370/8096] Linking CXX shared library lib/libMLIRSCFTransformOps.so.22.0git
[5371/8096] Linking CXX shared library lib/libMLIRMemRefTransformOps.so.22.0git
[5372/8096] Building AMDGPUGenSubtargetInfo.inc...
[5373/8096] Building AMDGPUGenDisassemblerTables.inc...
[5374/8096] Linking CXX shared library lib/libMLIRArmSMEToLLVM.so.22.0git
[5375/8096] Building AMDGPUGenSearchableTables.inc...
[5376/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5377/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5378/8096] Building AMDGPUGenCallingConv.inc...
[5379/8096] Building AMDGPUGenAsmWriter.inc...
[5380/8096] Building AMDGPUGenGlobalISel.inc...
[5381/8096] Building AMDGPUGenDAGISel.inc...
[5382/8096] Building AMDGPUGenInstrInfo.inc...
[5383/8096] Building AMDGPUGenAsmMatcher.inc...
[5384/8096] Building AMDGPUGenRegisterInfo.inc...
[5385/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/159666