[llvm] [InstCombine] Preserve profile after folding select instructions with conditionals (PR #159666)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 3 10:23:57 PDT 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/24035

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[4917/8096] Building CXX object tools/mlir/test/lib/Conversion/FuncToLLVM/CMakeFiles/MLIRTestFuncToLLVM.dir/TestConvertCallOp.cpp.o
[4918/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestAffineLoopParametricTiling.cpp.o
[4919/8096] Creating library symlink lib/libMLIRVCIXDialect.so
[4920/8096] Linking CXX shared library lib/libMLIRComplexDivisionConversion.so.22.0git
[4921/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestAffineDataCopy.cpp.o
[4922/8096] Linking CXX shared library lib/libMLIRSparseTensorDialect.so.22.0git
[4923/8096] Creating library symlink lib/libMLIRComplexDivisionConversion.so
[4924/8096] Creating library symlink lib/libMLIRSparseTensorDialect.so
[4925/8096] Linking CXX shared library lib/libMLIRTargetLLVMIRImport.so.22.0git
[4926/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: In function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0xe3): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[4927/8096] Linking CXX shared library lib/libMLIRCAPIArith.so.22.0git
[4928/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[4929/8096] Creating library symlink lib/libMLIRTargetLLVMIRImport.so
[4930/8096] Linking CXX shared library lib/libMLIRXeVMDialect.so.22.0git
[4931/8096] Linking CXX shared library lib/libMLIRReduce.so.22.0git
[4932/8096] Linking CXX shared library lib/libMLIRCAPIEmitC.so.22.0git
[4933/8096] Linking CXX shared library lib/libMLIRCAPIControlFlow.so.22.0git
[4934/8096] Linking CXX shared library lib/libMLIRFuncToEmitC.so.22.0git
[4935/8096] Linking CXX shared library lib/libMLIRCAPIIndex.so.22.0git
[4936/8096] Linking CXX shared library lib/libMLIRCAPIIRDL.so.22.0git
[4937/8096] Linking CXX shared library lib/libMLIRCAPIMath.so.22.0git
[4938/8096] Linking CXX shared library lib/libMLIRComplexToROCDLLibraryCalls.so.22.0git
[4939/8096] Linking CXX shared library lib/libMLIRCAPIFunc.so.22.0git
[4940/8096] Linking CXX shared library lib/libMLIRComplexToLibm.so.22.0git
[4941/8096] Linking CXX shared library lib/libMLIRCAPIPDL.so.22.0git
[4942/8096] Linking CXX shared library lib/libMLIRCAPIQuant.so.22.0git
[4943/8096] Linking CXX shared library lib/libMLIRMathToEmitC.so.22.0git
[4944/8096] Linking CXX shared library lib/libMLIRMemRefDialect.so.22.0git
[4945/8096] Linking CXX shared library lib/libMLIRTransforms.so.22.0git
[4946/8096] Linking CXX shared library lib/libMLIRCAPILLVM.so.22.0git
[4947/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[4948/8096] Linking CXX shared library lib/libMLIROpenMPDialect.so.22.0git
[4949/8096] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[4950/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4951/8096] Building AMDGPUGenCallingConv.inc...
[4952/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
In file included from /usr/include/c++/8/cassert:44,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:40,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Transforms/IPO/MemProfContextDisambiguation.h:18,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/LTO/LTO.cpp:60:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h: In member function ‘llvm::ArrayRef<llvm::InstrProfValueSiteRecord> llvm::InstrProfRecord::getValueSitesForKind(uint32_t) const’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:1028:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     assert(IPVK_First <= ValueKind && ValueKind <= IPVK_Last &&
Step 7 (build cmake config) failure: build cmake config (failure)
...
[4917/8096] Building CXX object tools/mlir/test/lib/Conversion/FuncToLLVM/CMakeFiles/MLIRTestFuncToLLVM.dir/TestConvertCallOp.cpp.o
[4918/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestAffineLoopParametricTiling.cpp.o
[4919/8096] Creating library symlink lib/libMLIRVCIXDialect.so
[4920/8096] Linking CXX shared library lib/libMLIRComplexDivisionConversion.so.22.0git
[4921/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestAffineDataCopy.cpp.o
[4922/8096] Linking CXX shared library lib/libMLIRSparseTensorDialect.so.22.0git
[4923/8096] Creating library symlink lib/libMLIRComplexDivisionConversion.so
[4924/8096] Creating library symlink lib/libMLIRSparseTensorDialect.so
[4925/8096] Linking CXX shared library lib/libMLIRTargetLLVMIRImport.so.22.0git
[4926/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: In function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0xe3): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[4927/8096] Linking CXX shared library lib/libMLIRCAPIArith.so.22.0git
[4928/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[4929/8096] Creating library symlink lib/libMLIRTargetLLVMIRImport.so
[4930/8096] Linking CXX shared library lib/libMLIRXeVMDialect.so.22.0git
[4931/8096] Linking CXX shared library lib/libMLIRReduce.so.22.0git
[4932/8096] Linking CXX shared library lib/libMLIRCAPIEmitC.so.22.0git
[4933/8096] Linking CXX shared library lib/libMLIRCAPIControlFlow.so.22.0git
[4934/8096] Linking CXX shared library lib/libMLIRFuncToEmitC.so.22.0git
[4935/8096] Linking CXX shared library lib/libMLIRCAPIIndex.so.22.0git
[4936/8096] Linking CXX shared library lib/libMLIRCAPIIRDL.so.22.0git
[4937/8096] Linking CXX shared library lib/libMLIRCAPIMath.so.22.0git
[4938/8096] Linking CXX shared library lib/libMLIRComplexToROCDLLibraryCalls.so.22.0git
[4939/8096] Linking CXX shared library lib/libMLIRCAPIFunc.so.22.0git
[4940/8096] Linking CXX shared library lib/libMLIRComplexToLibm.so.22.0git
[4941/8096] Linking CXX shared library lib/libMLIRCAPIPDL.so.22.0git
[4942/8096] Linking CXX shared library lib/libMLIRCAPIQuant.so.22.0git
[4943/8096] Linking CXX shared library lib/libMLIRMathToEmitC.so.22.0git
[4944/8096] Linking CXX shared library lib/libMLIRMemRefDialect.so.22.0git
[4945/8096] Linking CXX shared library lib/libMLIRTransforms.so.22.0git
[4946/8096] Linking CXX shared library lib/libMLIRCAPILLVM.so.22.0git
[4947/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[4948/8096] Linking CXX shared library lib/libMLIROpenMPDialect.so.22.0git
[4949/8096] Linking CXX shared library lib/libMLIRROCDLDialect.so.22.0git
[4950/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4951/8096] Building AMDGPUGenCallingConv.inc...
[4952/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
In file included from /usr/include/c++/8/cassert:44,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:40,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/Transforms/IPO/MemProfContextDisambiguation.h:18,
                 from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/LTO/LTO.cpp:60:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h: In member function ‘llvm::ArrayRef<llvm::InstrProfValueSiteRecord> llvm::InstrProfRecord::getValueSitesForKind(uint32_t) const’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include/llvm/ProfileData/InstrProf.h:1028:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     assert(IPVK_First <= ValueKind && ValueKind <= IPVK_Last &&

```

</details>

https://github.com/llvm/llvm-project/pull/159666

More information about the llvm-commits mailing list