[llvm] [InstCombine] Preserve profile after folding select instructions with conditionals (PR #159666)

Fri Oct 3 10:23:42 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/24012

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5229/8096] Creating library symlink lib/libLLVMSPIRVAnalysis.so
[5230/8096] Linking CXX shared library lib/libMLIRAMDGPUUtils.so.22.0git
[5231/8096] Linking CXX shared library lib/libMLIRArmSVETransforms.so.22.0git
[5232/8096] Creating library symlink lib/libMLIRX86VectorTransforms.so
[5233/8096] Creating library symlink lib/libMLIRAMDGPUUtils.so
[5234/8096] Linking CXX shared library lib/libMLIRArithTestPasses.so.22.0git
[5235/8096] Creating library symlink lib/libMLIRArmSVETransforms.so
[5236/8096] Linking CXX shared library lib/libMLIRArithToLLVM.so.22.0git
[5237/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5238/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2c3): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5239/8096] Creating library symlink lib/libMLIRArithToLLVM.so
[5240/8096] Creating library symlink lib/libLLVMInstrumentation.so
[5241/8096] Linking CXX shared library lib/libMLIRTosaToArith.so.22.0git
[5242/8096] Linking CXX shared library lib/libMLIRShardTransforms.so.22.0git
[5243/8096] Linking CXX shared library lib/libMLIRAffineToStandard.so.22.0git
[5244/8096] Linking CXX shared library lib/libMLIRTosaToSCF.so.22.0git
[5245/8096] Linking CXX shared library lib/libMLIRTosaToMLProgram.so.22.0git
[5246/8096] Linking CXX shared library lib/libMLIRTosaToTensor.so.22.0git
[5247/8096] Linking CXX shared library lib/libMLIRNVGPUTransforms.so.22.0git
[5248/8096] Linking CXX shared library lib/libMLIRArithToArmSME.so.22.0git
[5249/8096] Linking CXX shared library lib/libMLIRArmSMEToSCF.so.22.0git
[5250/8096] Linking CXX shared library lib/libMLIRSparseTensorUtils.so.22.0git
[5251/8096] Linking CXX shared library lib/libMLIRLinalgUtils.so.22.0git
[5252/8096] Linking CXX shared library lib/libMLIRVectorToArmSME.so.22.0git
[5253/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5254/8096] Linking CXX shared library lib/libMLIRAffineTransformOps.so.22.0git
[5255/8096] Linking CXX shared library lib/libMLIRBufferizationTransformOps.so.22.0git
[5256/8096] Linking CXX shared library lib/libMLIRMemRefTransforms.so.22.0git
[5257/8096] Linking CXX shared library lib/libMLIRArithToAMDGPU.so.22.0git
[5258/8096] Linking CXX shared library lib/libMLIRAMDGPUToROCDL.so.22.0git
[5259/8096] Linking CXX shared library lib/libMLIRAMDGPUTransforms.so.22.0git
[5260/8096] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5261/8096] Building AMDGPUGenSearchableTables.inc...
[5262/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5263/8096] Building AMDGPUGenCallingConv.inc...
[5264/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5265/8096] Building AMDGPUGenAsmWriter.inc...
[5266/8096] Building AMDGPUGenDAGISel.inc...
[5267/8096] Building AMDGPUGenGlobalISel.inc...
[5268/8096] Building AMDGPUGenInstrInfo.inc...
[5269/8096] Building AMDGPUGenAsmMatcher.inc...
[5270/8096] Building AMDGPUGenRegisterInfo.inc...
[5271/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5229/8096] Creating library symlink lib/libLLVMSPIRVAnalysis.so
[5230/8096] Linking CXX shared library lib/libMLIRAMDGPUUtils.so.22.0git
[5231/8096] Linking CXX shared library lib/libMLIRArmSVETransforms.so.22.0git
[5232/8096] Creating library symlink lib/libMLIRX86VectorTransforms.so
[5233/8096] Creating library symlink lib/libMLIRAMDGPUUtils.so
[5234/8096] Linking CXX shared library lib/libMLIRArithTestPasses.so.22.0git
[5235/8096] Creating library symlink lib/libMLIRArmSVETransforms.so
[5236/8096] Linking CXX shared library lib/libMLIRArithToLLVM.so.22.0git
[5237/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5238/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2c3): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5239/8096] Creating library symlink lib/libMLIRArithToLLVM.so
[5240/8096] Creating library symlink lib/libLLVMInstrumentation.so
[5241/8096] Linking CXX shared library lib/libMLIRTosaToArith.so.22.0git
[5242/8096] Linking CXX shared library lib/libMLIRShardTransforms.so.22.0git
[5243/8096] Linking CXX shared library lib/libMLIRAffineToStandard.so.22.0git
[5244/8096] Linking CXX shared library lib/libMLIRTosaToSCF.so.22.0git
[5245/8096] Linking CXX shared library lib/libMLIRTosaToMLProgram.so.22.0git
[5246/8096] Linking CXX shared library lib/libMLIRTosaToTensor.so.22.0git
[5247/8096] Linking CXX shared library lib/libMLIRNVGPUTransforms.so.22.0git
[5248/8096] Linking CXX shared library lib/libMLIRArithToArmSME.so.22.0git
[5249/8096] Linking CXX shared library lib/libMLIRArmSMEToSCF.so.22.0git
[5250/8096] Linking CXX shared library lib/libMLIRSparseTensorUtils.so.22.0git
[5251/8096] Linking CXX shared library lib/libMLIRLinalgUtils.so.22.0git
[5252/8096] Linking CXX shared library lib/libMLIRVectorToArmSME.so.22.0git
[5253/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5254/8096] Linking CXX shared library lib/libMLIRAffineTransformOps.so.22.0git
[5255/8096] Linking CXX shared library lib/libMLIRBufferizationTransformOps.so.22.0git
[5256/8096] Linking CXX shared library lib/libMLIRMemRefTransforms.so.22.0git
[5257/8096] Linking CXX shared library lib/libMLIRArithToAMDGPU.so.22.0git
[5258/8096] Linking CXX shared library lib/libMLIRAMDGPUToROCDL.so.22.0git
[5259/8096] Linking CXX shared library lib/libMLIRAMDGPUTransforms.so.22.0git
[5260/8096] Linking CXX shared library lib/libMLIRSPIRVDialect.so.22.0git
[5261/8096] Building AMDGPUGenSearchableTables.inc...
[5262/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5263/8096] Building AMDGPUGenCallingConv.inc...
[5264/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5265/8096] Building AMDGPUGenAsmWriter.inc...
[5266/8096] Building AMDGPUGenDAGISel.inc...
[5267/8096] Building AMDGPUGenGlobalISel.inc...
[5268/8096] Building AMDGPUGenInstrInfo.inc...
[5269/8096] Building AMDGPUGenAsmMatcher.inc...
[5270/8096] Building AMDGPUGenRegisterInfo.inc...
[5271/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/159666