[llvm] [InstCombine] Preserve profile after folding select instructions with conditionals (PR #159666)

Fri Oct 3 10:23:18 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/28468

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
32.304 [1050/10/5212] Linking CXX executable unittests/DebugInfo/MSF/DebugInfoMSFTests
32.333 [1049/10/5213] Linking CXX executable unittests/DebugInfo/Symbolizer/DebugInfoSymbolizerTests
32.363 [1048/10/5214] Linking CXX executable unittests/Bitcode/BitcodeTests
32.390 [1047/10/5215] Linking CXX executable unittests/DebugInfo/GSYM/DebugInfoGSYMTests
32.422 [1046/10/5216] Linking CXX executable unittests/Demangle/DemangleTests
32.440 [1045/10/5217] Linking CXX executable unittests/DebugInfo/PDB/DebugInfoPDBTests
32.471 [1044/10/5218] Linking CXX executable unittests/FileCheck/FileCheckTests
32.606 [1043/10/5219] Linking CXX executable unittests/Debuginfod/DebuginfodTests
32.619 [1042/10/5220] Linking CXX executable unittests/InterfaceStub/InterfaceStubTests
32.624 [1041/10/5221] Linking CXX executable unittests/Analysis/AnalysisTests
FAILED: [code=1] unittests/Analysis/AnalysisTests 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-dead_strip -Wl,-no_warn_duplicate_libraries -rdynamic unittests/Analysis/CMakeFiles/AnalysisTests.dir/AliasAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/AliasSetTrackerTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/AssumeBundleQueriesTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/BasicAliasAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/BlockFrequencyInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/BranchProbabilityInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/CallGraphTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/CaptureTrackingTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/CFGTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/CGSCCPassManagerTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ConstraintSystemTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/CtxProfAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/DDGTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/DomTreeUpdaterTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/DXILResourceTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/EphemeralValuesCacheTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/GraphWriterTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/GlobalsModRefTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/FunctionPropertiesAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/InlineCostTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/IR2VecTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/IRSimilarityIdentifierTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/IVDescriptorsTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/LastRunTrackingAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/LazyCallGraphTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/LoadsTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/LoopInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/LoopNestTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/MemoryBuiltinsTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/MemoryProfileInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/MemorySSATest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/MLModelRunnerTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/PhiValuesTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineAdvisorAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineOrderAnalysisTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ProfileSummaryInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ReplaceWithVecLibTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ScalarEvolutionTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/SparsePropagation.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/TargetLibraryInfoTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/TensorSpecTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/TBAATest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/UnrollAnalyzerTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ValueLatticeTest.cpp.o unittests/Analysis/CMakeFiles/AnalysisTests.dir/ValueTrackingTest.cpp.
  lib/libLLVMAsmParser.a  lib/libLLVMCodeGen.a  lib/libLLVMCore.a  lib/libLLVMInstrumentation.a  lib/libLLVMPasses.a  lib/libLLVMSupport.a  lib/libLLVMTargetParser.a  lib/libLLVMTransformUtils.a  lib/libLLVMipo.a  lib/libLLVMSupport.a  lib/libllvm_gtest_main.a  lib/libllvm_gtest.a  lib/libLLVMTestingSupport.a  lib/libLLVMCFGuard.a  lib/libLLVMGlobalISel.a  lib/libLLVMSelectionDAG.a  lib/libLLVMCodeGen.a  lib/libLLVMCGData.a  lib/libLLVMObjCARCOpts.a  lib/libLLVMCodeGenTypes.a  lib/libLLVMTarget.a  lib/libLLVMCoroutines.a  lib/libLLVMipo.a  lib/libLLVMInstrumentation.a  lib/libLLVMBitWriter.a  lib/libLLVMFrontendOpenMP.a  lib/libLLVMFrontendOffloading.a  lib/libLLVMObjectYAML.a  lib/libLLVMFrontendAtomic.a  lib/libLLVMFrontendDirective.a  lib/libLLVMLinker.a  lib/libLLVMScalarOpts.a  lib/libLLVMAggressiveInstCombine.a  lib/libLLVMHipStdPar.a  lib/libLLVMInstCombine.a  lib/libLLVMIRPrinter.a  lib/libLLVMVectorize.a  lib/libLLVMTransformUtils.a  lib/libLLVMSandboxIR.a  lib/libLLVMAnalysis.a  lib/libLLVMFrontendHLSL.a  lib/libLLVMProfileData.a  lib/libLLVMSymbolize.a  lib/libLLVMDebugInfoGSYM.a  lib/libLLVMDebugInfoPDB.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMDebugInfoMSF.a  lib/libLLVMDebugInfoBTF.a  lib/libLLVMDebugInfoDWARF.a  lib/libLLVMObject.a  lib/libLLVMIRReader.a  lib/libLLVMAsmParser.a  lib/libLLVMBitReader.a  lib/libLLVMMCParser.a  lib/libLLVMMC.a  lib/libLLVMTextAPI.a  lib/libLLVMDebugInfoDWARFLowLevel.a  lib/libLLVMCore.a  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libllvm_gtest.a  lib/libLLVMSupport.a  lib/libLLVMDemangle.a  -lm  /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/lib/libz.tbd  /opt/homebrew/lib/libzstd.dylib  -lpthread && :
Undefined symbols for architecture arm64:
  "_ProfcheckDisableMetadataFixes", referenced from:
      llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::$_10::operator()(bool, llvm::Value*, llvm::Value*) const in libLLVMInstCombine.a[13](InstCombineSelect.cpp.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
32.743 [1041/9/5222] Linking CXX executable unittests/LineEditor/LineEditorTests
32.780 [1041/8/5223] Linking CXX executable unittests/ExecutionEngine/ExecutionEngineTests
32.812 [1041/7/5224] Linking CXX executable unittests/Linker/LinkerTests
32.842 [1041/6/5225] Linking CXX executable unittests/FuzzMutate/FuzzMutateTests
32.874 [1041/5/5226] Linking CXX executable unittests/IR/IRTests
FAILED: [code=1] unittests/IR/IRTests 
: && /usr/bin/clang++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-dead_strip -Wl,-no_warn_duplicate_libraries unittests/IR/CMakeFiles/IRTests.dir/AbstractCallSiteTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/AsmWriterTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/AttributesTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/BasicBlockTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/BasicBlockDbgInfoTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/CFGBuilder.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ConstantFPRangeTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ConstantRangeTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ConstantRangeListTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ConstantsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DataLayoutTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DebugInfoTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DebugTypeODRUniquingTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DemandedBitsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DominatorTreeTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DominatorTreeBatchUpdatesTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/DroppedVariableStatsIRTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/FunctionTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/GlobalObjectTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/PassBuilderCallbacksTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/IRBuilderTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/InstructionsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/IntrinsicsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/LegacyPassManagerTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/MDBuilderTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/MemoryModelRelaxationAnnotationsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ManglerTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/MetadataTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ModuleTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ModuleSummaryIndexTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/PassManagerTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/PatternMatch.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ShuffleVectorInstTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/StructuralHashTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/RuntimeLibcallsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/TimePassesTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/TypesTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/UseTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/UserTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ValueHandleTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ValueMapTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/ValueTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/VectorTypeUtilsTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/VectorTypesTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/VerifierTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/VFABIDemanglerTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/VPIntrinsicTest.cpp.o unittests/IR/CMakeFiles/IRTests.dir/CoreBindings.cpp.o -o unittests/IR/IRTests  lib/libLLVMAnalysis.a  lib/libLLVMAsmParser.a  lib/libLLVMCore.a  lib/libLLVMSupport.a  lib/libLLVMPasses.a  lib/libLLVMTargetParser.a  lib/libLLVMTransformUtils.a  lib/libLLVMScalarOpts.a  lib/libLLVMSupport.a  lib/libllvm_gtest_main.a  lib/libllvm_gtest.a  lib/libLLVMTestingSupport.a  lib/libLLVMCFGuard.a  lib/libLLVMGlobalISel.a  lib/libLLVMSelectionDAG.a  lib/libLLVMCodeGen.a  lib/libLLVMCGData.a  lib/libLLVMCodeGenTypes.a  lib/libLLVMCoroutines.a  lib
alarOpts.a  lib/libLLVMAggressiveInstCombine.a  lib/libLLVMFrontendOffloading.a  lib/libLLVMObjectYAML.a  lib/libLLVMFrontendAtomic.a  lib/libLLVMFrontendDirective.a  lib/libLLVMLinker.a  lib/libLLVMInstCombine.a  lib/libLLVMIRPrinter.a  lib/libLLVMObjCARCOpts.a  lib/libLLVMTarget.a  lib/libLLVMVectorize.a  lib/libLLVMSandboxIR.a  lib/libLLVMInstrumentation.a  lib/libLLVMTransformUtils.a  lib/libLLVMAnalysis.a  lib/libLLVMFrontendHLSL.a  lib/libLLVMProfileData.a  lib/libLLVMSymbolize.a  lib/libLLVMDebugInfoGSYM.a  lib/libLLVMDebugInfoPDB.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMDebugInfoMSF.a  lib/libLLVMDebugInfoBTF.a  lib/libLLVMDebugInfoDWARF.a  lib/libLLVMObject.a  lib/libLLVMIRReader.a  lib/libLLVMAsmParser.a  lib/libLLVMBitReader.a  lib/libLLVMCore.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libLLVMMCParser.a  lib/libLLVMTextAPI.a  lib/libLLVMDebugInfoDWARFLowLevel.a  lib/libLLVMMC.a  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libllvm_gtest.a  lib/libLLVMSupport.a  lib/libLLVMDemangle.a  -lm  /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/lib/libz.tbd  /opt/homebrew/lib/libzstd.dylib  -lpthread && :
Undefined symbols for architecture arm64:
  "_ProfcheckDisableMetadataFixes", referenced from:
      llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::$_10::operator()(bool, llvm::Value*, llvm::Value*) const in libLLVMInstCombine.a[13](InstCombineSelect.cpp.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
32.897 [1041/4/5227] Linking CXX executable unittests/Frontend/LLVMFrontendTests
33.114 [1041/3/5228] Building AArch64GenSubtargetInfo.inc...
34.602 [1041/2/5229] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
35.511 [1041/1/5230] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/159666