[llvm] [InstCombine] Preserve profile after folding select instructions with conditionals (PR #159666)

Fri Oct 3 10:22:15 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/25223

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5286/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestLoopFusion.cpp.o
[5287/8096] Linking CXX shared library lib/libMLIRSPIRVUtils.so.22.0git
[5288/8096] Linking CXX shared library lib/libMLIRSPIRVModuleCombiner.so.22.0git
[5289/8096] Linking CXX shared library lib/libMLIRSPIRVSerialization.so.22.0git
[5290/8096] Linking CXX shared library lib/libMLIRTosaToLinalg.so.22.0git
[5291/8096] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestAlgebraicSimplification.cpp.o
[5292/8096] Creating library symlink lib/libMLIRSPIRVUtils.so
[5293/8096] Creating library symlink lib/libMLIRSPIRVModuleCombiner.so
[5294/8096] Creating library symlink lib/libMLIRSPIRVSerialization.so
[5295/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2eb): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5296/8096] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestPolynomialApproximation.cpp.o
[5297/8096] Building AMDGPUGenDisassemblerTables.inc...
[5298/8096] Creating library symlink lib/libMLIRTosaToLinalg.so
[5299/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5300/8096] Building CXX object tools/mlir/test/lib/Dialect/LLVM/CMakeFiles/MLIRLLVMTestPasses.dir/TestPatterns.cpp.o
[5301/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestEmulateNarrowType.cpp.o
[5302/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestMultiBuffer.cpp.o
[5303/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestComposeSubView.cpp.o
[5304/8096] Linking CXX shared library lib/libMLIRBufferizationPipelines.so.22.0git
[5305/8096] Linking CXX shared library lib/libMLIRTensorTransformOps.so.22.0git
[5306/8096] Linking CXX shared library lib/libMLIRFuncTransformOps.so.22.0git
[5307/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5308/8096] Linking CXX shared library lib/libMLIRAsyncToLLVM.so.22.0git
[5309/8096] Linking CXX shared library lib/libMLIRSCFTransforms.so.22.0git
[5310/8096] Linking CXX shared library lib/libMLIROpenMPToLLVM.so.22.0git
[5311/8096] Building AMDGPUGenMCCodeEmitter.inc...
[5312/8096] Linking CXX shared library lib/libMLIRAMDGPUTransforms.so.22.0git
[5313/8096] Linking CXX shared library lib/libMLIRSPIRVTranslateRegistration.so.22.0git
[5314/8096] Linking CXX shared library lib/libMLIRVectorTransforms.so.22.0git
[5315/8096] Linking CXX shared library lib/libMLIRAMDGPUToROCDL.so.22.0git
[5316/8096] Linking CXX shared library lib/libMLIRArithToAMDGPU.so.22.0git
[5317/8096] Linking CXX shared library lib/libMLIRSPIRVToLLVM.so.22.0git
[5318/8096] Building AMDGPUGenSearchableTables.inc...
[5319/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5320/8096] Building AMDGPUGenCallingConv.inc...
[5321/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5322/8096] Building AMDGPUGenAsmWriter.inc...
[5323/8096] Building AMDGPUGenGlobalISel.inc...
[5324/8096] Building AMDGPUGenDAGISel.inc...
[5325/8096] Building AMDGPUGenInstrInfo.inc...
[5326/8096] Building AMDGPUGenAsmMatcher.inc...
[5327/8096] Building AMDGPUGenRegisterInfo.inc...
[5328/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5286/8096] Building CXX object tools/mlir/test/lib/Dialect/Affine/CMakeFiles/MLIRAffineTransformsTestPasses.dir/TestLoopFusion.cpp.o
[5287/8096] Linking CXX shared library lib/libMLIRSPIRVUtils.so.22.0git
[5288/8096] Linking CXX shared library lib/libMLIRSPIRVModuleCombiner.so.22.0git
[5289/8096] Linking CXX shared library lib/libMLIRSPIRVSerialization.so.22.0git
[5290/8096] Linking CXX shared library lib/libMLIRTosaToLinalg.so.22.0git
[5291/8096] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestAlgebraicSimplification.cpp.o
[5292/8096] Creating library symlink lib/libMLIRSPIRVUtils.so
[5293/8096] Creating library symlink lib/libMLIRSPIRVModuleCombiner.so
[5294/8096] Creating library symlink lib/libMLIRSPIRVSerialization.so
[5295/8096] Linking CXX shared library lib/libLLVMInstCombine.so.22.0git
FAILED: lib/libLLVMInstCombine.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMInstCombine.so.22.0git -o lib/libLLVMInstCombine.so.22.0git lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAddSub.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAtomicRMW.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineAndOrXor.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCalls.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCasts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineCompares.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineLoadStoreAlloca.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineMulDivRem.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineNegator.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombinePHI.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineShifts.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSimplifyDemanded.cpp.o lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineVectorOps.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib:"  lib/libLLVMTransformUtils.so.22.0git  lib/libLLVMAnalysis.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-ubuntu-22-cmake-build-only/build/lib && :
/usr/bin/ld: lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstCombineSelect.cpp.o: in function `llvm::InstCombinerImpl::visitSelectInst(llvm::SelectInst&)::{lambda(bool, llvm::Value*, llvm::Value*)#2}::operator()(bool, llvm::Value*, llvm::Value*) const':
InstCombineSelect.cpp:(.text._ZZN4llvm16InstCombinerImpl15visitSelectInstERNS_10SelectInstEENKUlbPNS_5ValueES4_E0_clEbS4_S4_+0x2eb): undefined reference to `ProfcheckDisableMetadataFixes'
collect2: error: ld returned 1 exit status
[5296/8096] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestPolynomialApproximation.cpp.o
[5297/8096] Building AMDGPUGenDisassemblerTables.inc...
[5298/8096] Creating library symlink lib/libMLIRTosaToLinalg.so
[5299/8096] Linking CXX shared library lib/libLLVMInstrumentation.so.22.0git
[5300/8096] Building CXX object tools/mlir/test/lib/Dialect/LLVM/CMakeFiles/MLIRLLVMTestPasses.dir/TestPatterns.cpp.o
[5301/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestEmulateNarrowType.cpp.o
[5302/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestMultiBuffer.cpp.o
[5303/8096] Building CXX object tools/mlir/test/lib/Dialect/MemRef/CMakeFiles/MLIRMemRefTestPasses.dir/TestComposeSubView.cpp.o
[5304/8096] Linking CXX shared library lib/libMLIRBufferizationPipelines.so.22.0git
[5305/8096] Linking CXX shared library lib/libMLIRTensorTransformOps.so.22.0git
[5306/8096] Linking CXX shared library lib/libMLIRFuncTransformOps.so.22.0git
[5307/8096] Linking CXX shared library lib/libLLVMVectorize.so.22.0git
[5308/8096] Linking CXX shared library lib/libMLIRAsyncToLLVM.so.22.0git
[5309/8096] Linking CXX shared library lib/libMLIRSCFTransforms.so.22.0git
[5310/8096] Linking CXX shared library lib/libMLIROpenMPToLLVM.so.22.0git
[5311/8096] Building AMDGPUGenMCCodeEmitter.inc...
[5312/8096] Linking CXX shared library lib/libMLIRAMDGPUTransforms.so.22.0git
[5313/8096] Linking CXX shared library lib/libMLIRSPIRVTranslateRegistration.so.22.0git
[5314/8096] Linking CXX shared library lib/libMLIRVectorTransforms.so.22.0git
[5315/8096] Linking CXX shared library lib/libMLIRAMDGPUToROCDL.so.22.0git
[5316/8096] Linking CXX shared library lib/libMLIRArithToAMDGPU.so.22.0git
[5317/8096] Linking CXX shared library lib/libMLIRSPIRVToLLVM.so.22.0git
[5318/8096] Building AMDGPUGenSearchableTables.inc...
[5319/8096] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5320/8096] Building AMDGPUGenCallingConv.inc...
[5321/8096] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5322/8096] Building AMDGPUGenAsmWriter.inc...
[5323/8096] Building AMDGPUGenGlobalISel.inc...
[5324/8096] Building AMDGPUGenDAGISel.inc...
[5325/8096] Building AMDGPUGenInstrInfo.inc...
[5326/8096] Building AMDGPUGenAsmMatcher.inc...
[5327/8096] Building AMDGPUGenRegisterInfo.inc...
[5328/8096] Building AMDGPUGenRegisterBank.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/159666