[llvm] Adding Matching and Inference Functionality to Propeller (PR #160706)

Rahman Lavaee via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 2 11:03:18 PDT 2025


================
@@ -1526,6 +1526,9 @@ void ELFState<ELFT>::writeSectionContent(
         }
         SHeader.sh_size += CBA.writeULEB128(BBE.Size);
         SHeader.sh_size += CBA.writeULEB128(BBE.Metadata);
+        if (FeatureOrErr->BBHash && BBE.Hash) {
----------------
rlavaee wrote:

Actually, this is not what I thought because BBE.Hash is std::optional. Since this is YAML, you should use `||` instead. So we would emit the hash if either the feature is enabled (even if BBE.Hash is zero) or BBE.Hash has value (even if feature is disabled). In the latter case, we don't need to enable the feature value. Please also use `BBE.Hash.has_value()` to disambiguate against value comparison.

https://github.com/llvm/llvm-project/pull/160706


More information about the llvm-commits mailing list