[llvm] [AMDGPU] Be less optimistic when allocating module scope lds (PR #161464)
Jon Chesterfield via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 30 17:56:57 PDT 2025
================
@@ -608,6 +608,8 @@ class AMDGPULowerModuleLDS {
? LDSToKernelsThatNeedToAccessItIndirectly[HybridModuleRoot]
: EmptySet;
+ const auto HybridModuleRootKernelsSize = HybridModuleRootKernels.size();
----------------
JonChesterfield wrote:
For ::size()? It's going to be some variant of integer.
I suppose it could be DenseSet::SizeType but that doesn't really say more than auto did.
Regardless, you can have whatever string of letters you prefer here. Or we can call the function repeatedly. Or actually implement set_is_equal in the ADT header which is what I looked for first.
https://github.com/llvm/llvm-project/pull/161464
More information about the llvm-commits
mailing list