[llvm] [test] llvm-ar: Fix inadvertent unXFAIL for Apple platforms (PR #159796)
Anthony Latsis via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 29 08:21:42 PDT 2025
https://github.com/AnthonyLatsis updated https://github.com/llvm/llvm-project/pull/159796
>From 8e34d6516595cea46940d5c95f2dd4b53f6c719d Mon Sep 17 00:00:00 2001
From: Anthony Latsis <alatsis at apple.com>
Date: Fri, 19 Sep 2025 15:44:50 +0100
Subject: [PATCH] [test] llvm-ar: Fix inadvertent unXFAIL for Apple platforms
The history of these XFAILs is clouded. Initially added as target-based
checks in
https://github.com/llvm/llvm-project/commit/629273ec09825b870ce53e6419296d73519b1e24
for somewhat vague reasons, soon after switched to host-based checks in
https://github.com/llvm/llvm-project/commit/20b2cd3c0bfe8f732bb135edb7f3c8436d005fe9
"due to the problem being related to the darwin host and not the
target", and recently reverted back to target-based in
https://github.com/llvm/llvm-project/pull/130144 because, to my
understanding, the tests can unexpectedly pass on arm64 macOS with
`llvm-ar` cross-compiled to baremetal arm64.
Anyway, the problem with the current `target={{.*}}-darwin{{.*}}` is
that the Swift build script uses Apple platform names like 'macosx', not
'darwin', for the LLVM target triple, e.g. `arm64-apple-macosx13.0`.
---
llvm/test/tools/llvm-ar/extract.test | 2 +-
llvm/test/tools/llvm-ar/print.test | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/test/tools/llvm-ar/extract.test b/llvm/test/tools/llvm-ar/extract.test
index bf46cc0743c7d..124d828398e55 100644
--- a/llvm/test/tools/llvm-ar/extract.test
+++ b/llvm/test/tools/llvm-ar/extract.test
@@ -1,5 +1,5 @@
## Test extract operation.
-# XFAIL: target={{.*}}-darwin{{.*}}
+# XFAIL: target={{.*}}-apple-{{.*}}
# RUN: rm -rf %t && mkdir -p %t/extracted/
diff --git a/llvm/test/tools/llvm-ar/print.test b/llvm/test/tools/llvm-ar/print.test
index 997c05f225a8b..e4f931a9c3774 100644
--- a/llvm/test/tools/llvm-ar/print.test
+++ b/llvm/test/tools/llvm-ar/print.test
@@ -1,5 +1,5 @@
## Test Print output
-# XFAIL: target={{.*}}-darwin{{.*}}
+# XFAIL: target={{.*}}-apple-{{.*}}
# RUN: rm -rf %t && mkdir -p %t
# RUN: echo file1 > %t/1.txt
More information about the llvm-commits
mailing list