[llvm] [AMDGPU][ASAN] Remove amdgpu-no-flat-scratch-init attribute from lowered kernels in amdgpu-sw-lower-lds pass (PR #160541)

[Matt Arsenault via llvm-commits]

arsenm wrote:

> We can't simply change the way the runtime is built. There are functions that must accept generic pointers. 

Which can be managed to minimize the use of generic pointers to that interface. The actual library content should not be using generic to access scratch 

> Removing an incorrectly added attribute seems like the right way to go. Do you disagree that the attribute has become incorrect?

I think any compiler runtime library needs to have its properties carefully controlled to not cause trouble for the compiler. There is no reason for such a cast to exist in the library. We should have a custom verification that we can assume none of these functions rely on any implicit arguments.



https://github.com/llvm/llvm-project/pull/160541