[llvm] Fix code quality issues. (PR #160851)

Marcos Maronas via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 26 03:39:25 PDT 2025


https://github.com/maarquitos14 created https://github.com/llvm/llvm-project/pull/160851

Fix Rule of Three/Five issues reported by static analysis tool.

>From ffc47165b6f58f6148694790cd5049c1e5a8462d Mon Sep 17 00:00:00 2001
From: Marcos Maronas <marcos.maronas at intel.com>
Date: Fri, 26 Sep 2025 12:27:16 +0200
Subject: [PATCH] Fix code quality issues.

---
 llvm/include/llvm/TextAPI/SymbolSet.h | 2 ++
 llvm/lib/CAS/InMemoryCAS.cpp          | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/llvm/include/llvm/TextAPI/SymbolSet.h b/llvm/include/llvm/TextAPI/SymbolSet.h
index 42c411acb6f9d..22f4124f40313 100644
--- a/llvm/include/llvm/TextAPI/SymbolSet.h
+++ b/llvm/include/llvm/TextAPI/SymbolSet.h
@@ -92,6 +92,8 @@ class SymbolSet {
 
 public:
   SymbolSet() = default;
+  SymbolSet(const SymbolSet &other) = delete;
+  SymbolSet &operator=(const SymbolSet &other) = delete;
   LLVM_ABI ~SymbolSet();
   LLVM_ABI Symbol *addGlobal(EncodeKind Kind, StringRef Name, SymbolFlags Flags,
                              const Target &Targ);
diff --git a/llvm/lib/CAS/InMemoryCAS.cpp b/llvm/lib/CAS/InMemoryCAS.cpp
index 255b89c15c4c5..c63ee70de0849 100644
--- a/llvm/lib/CAS/InMemoryCAS.cpp
+++ b/llvm/lib/CAS/InMemoryCAS.cpp
@@ -57,6 +57,9 @@ class InMemoryObject {
   InMemoryObject() = delete;
   InMemoryObject(InMemoryObject &&) = delete;
   InMemoryObject(const InMemoryObject &) = delete;
+  InMemoryObject &operator=(const InMemoryObject &) = delete;
+  InMemoryObject &operator=(InMemoryObject &&) = delete;
+  virtual ~InMemoryObject() = default;
 
 protected:
   InMemoryObject(Kind K, const InMemoryIndexValueT &I) : IndexAndKind(&I, K) {}



More information about the llvm-commits mailing list