[llvm] [Support] Consolidate runOnNewStack (NFC) (PR #160816)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 25 23:38:02 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
This patch consolidates two implementations of runOnNewStack with
"if constexpr".
---
Full diff: https://github.com/llvm/llvm-project/pull/160816.diff
1 Files Affected:
- (modified) llvm/include/llvm/Support/ProgramStack.h (+8-10)
``````````diff
diff --git a/llvm/include/llvm/Support/ProgramStack.h b/llvm/include/llvm/Support/ProgramStack.h
index 0dd8235b90c06..13729a2990588 100644
--- a/llvm/include/llvm/Support/ProgramStack.h
+++ b/llvm/include/llvm/Support/ProgramStack.h
@@ -46,17 +46,15 @@ LLVM_ABI unsigned getDefaultStackSize();
LLVM_ABI void runOnNewStack(unsigned StackSize, function_ref<void()> Fn);
template <typename R, typename... Ts>
-std::enable_if_t<!std::is_same_v<R, void>, R>
-runOnNewStack(unsigned StackSize, function_ref<R(Ts...)> Fn, Ts &&...Args) {
- std::optional<R> Ret;
- runOnNewStack(StackSize, [&]() { Ret = Fn(std::forward<Ts>(Args)...); });
- return std::move(*Ret);
-}
-
-template <typename... Ts>
-void runOnNewStack(unsigned StackSize, function_ref<void(Ts...)> Fn,
+auto runOnNewStack(unsigned StackSize, function_ref<R(Ts...)> Fn,
Ts &&...Args) {
- runOnNewStack(StackSize, [&]() { Fn(std::forward<Ts>(Args)...); });
+ if constexpr (std::is_same_v<R, void>) {
+ runOnNewStack(StackSize, [&]() { Fn(std::forward<Ts>(Args)...); });
+ } else {
+ std::optional<R> Ret;
+ runOnNewStack(StackSize, [&]() { Ret = Fn(std::forward<Ts>(Args)...); });
+ return std::move(*Ret);
+ }
}
} // namespace llvm
``````````
</details>
https://github.com/llvm/llvm-project/pull/160816
More information about the llvm-commits
mailing list