[llvm] [runtimes] Fix duplicate BUILTINS_CMAKE_ARGS/RUNTIMES_CMAKE_ARGS (PR #160631)

Andrew Haberlandt via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 25 14:12:33 PDT 2025


ndrewh wrote:

> no canon name != BUILTIN needs the BUILTIN args

The two lines that were changed in this diff are in invocations of llvm_ExternalProject_Add(

The first is `llvm_ExternalProject_Add(builtins` and the second is `llvm_ExternalProject_Add(runtimes`. Therefore in these two invocations, `nameCanon` is `BUILTINS` and `RUNTIMES`, respectively. These are the only two invocations of `llvm_ExternalProject_Add` that are affected, so `nameCanon` having any other value would be completely unaffected by this PR.


https://github.com/llvm/llvm-project/pull/160631


More information about the llvm-commits mailing list