[llvm] [TII] Split isTrivialReMaterializable into two versions [nfc] (PR #160377)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 25 07:54:33 PDT 2025


================
@@ -2212,11 +2212,7 @@ findPrologueEndLoc(const MachineFunction *MF) {
       -> std::optional<std::pair<const MachineInstr *, bool>> {
     // Is this instruction trivial data shuffling or frame-setup?
     bool isCopy = (TII.isCopyInstr(MI) ? true : false);
-    bool isTrivRemat =
-        TII.isTriviallyReMaterializable(MI) &&
-        llvm::all_of(MI.all_uses(), [](const MachineOperand &MO) {
-          return MO.getReg().isVirtual();
-        });
+    bool isTrivRemat = TII.isTriviallyReMaterializable(MI);
----------------
preames wrote:

Thank you for flagging this.  I'm going to put a note on each review for later reference as this could be quite confusing later when digging through history.  

https://github.com/llvm/llvm-project/pull/160377


More information about the llvm-commits mailing list