[llvm] [LAA] Fix non-NFC parts of 1aded51 (PR #160701)

Igor Kirillov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 25 06:52:49 PDT 2025


https://github.com/igogo-x86 approved this pull request.

LGTM!
I tried to find a nicer way to check SCEV for zero and found this in ScalarEvolution.cpp:
```
    const SCEV *Zero = SE.getZero(B->getType());
    if (!SE.isKnownPredicate(CmpInst::ICMP_EQ, URem, Zero))
```
But I am not sure we need the strength behind `isKnownPredicate` and it may become non-NFC again

https://github.com/llvm/llvm-project/pull/160701


More information about the llvm-commits mailing list