[llvm] [DirectX] Updating DXContainer Yaml to represent Root Signature 1.2 (PR #159659)

Finn Plummer via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 23 11:53:29 PDT 2025


================
@@ -33,7 +33,9 @@ static uint32_t rewriteOffsetToCurrentByte(raw_svector_ostream &Stream,
 size_t RootSignatureDesc::getSize() const {
   uint32_t StaticSamplersOffset = computeStaticSamplersOffset();
   size_t StaticSamplersSize =
-      StaticSamplers.size() * sizeof(dxbc::RTS0::v1::StaticSampler);
+      (Version > 2 ? sizeof(dxbc::RTS0::v3::StaticSampler)
+                   : sizeof(dxbc::RTS0::v1::StaticSampler)) *
----------------
inbelic wrote:

very nitpicky: it would follow the pattern elsewhere in this size computation to use an if-else chain, which would technically be easier to extend for any future version

https://github.com/llvm/llvm-project/pull/159659


More information about the llvm-commits mailing list