[llvm] [AMDGPU][TargetLowering] Allow forming overflow op if it is legal (PR #156266)

[Matt Arsenault via llvm-commits]

================
@@ -3455,6 +3455,10 @@ class LLVM_ABI TargetLoweringBase {
   /// matching of other patterns.
   virtual bool shouldFormOverflowOp(unsigned Opcode, EVT VT,
                                     bool MathUsed) const {
+    // Form it if it is legal.
+    if (isOperationLegal(Opcode, VT))
+      return true;
+
----------------
arsenm wrote:

Right, the vector check is also nonsense. I would expect this to be a pure legality check without these random special cases thrown in

https://github.com/llvm/llvm-project/pull/156266