[llvm] Move the preserve-{bc,ll}-uselistorder options out of individual tools, make them global defaults for AsmWriter and BitcodeWriter (PR #160079)

[Mingjie Xu via llvm-commits]

================
@@ -118,6 +118,11 @@ static cl::opt<bool>
 #endif
                                 cl::desc(""));
 
+static cl::opt<bool> PreserveBitcodeUseListOrder(
+    "preserve-bc-uselistorder",
+    cl::desc("Preserve use-list order when writing LLVM bitcode."),
+    cl::init(false), cl::Hidden);
----------------
Enna1 wrote:

Yes, `-preserve-bc-uselistorder` defaults to true in all individual tools.
But in `llvm::WriteBitcodeToFile`, parameter `ShouldPreserveUseListOrder` defaults to false. https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Bitcode/BitcodeWriter.h#L134

To make global `-preserve-bc-uselistorder` taking precedence, `ShouldPreserveUseListOrder || PreserveBitcodeUseListOrder` is  used in `ModuleBitcodeWriterBase`'s constructor, 
so this has to be false here.



https://github.com/llvm/llvm-project/pull/160079