[compiler-rt] Add API to temporalily disable usage of ASAN's fake stack (PR #160135)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions inc,cpp,h -- compiler-rt/test/asan/TestCases/disable_fake_stack.cpp compiler-rt/include/sanitizer/asan_interface.h compiler-rt/lib/asan/asan_fake_stack.cpp compiler-rt/lib/asan/asan_fake_stack.h compiler-rt/lib/asan/asan_interface.inc compiler-rt/lib/asan/asan_thread.cpp compiler-rt/lib/asan/asan_thread.h compiler-rt/lib/asan_abi/asan_abi.cpp compiler-rt/lib/asan_abi/asan_abi.h compiler-rt/lib/asan_abi/asan_abi_shim.cpp
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/lib/asan/asan_fake_stack.cpp b/compiler-rt/lib/asan/asan_fake_stack.cpp
index e1772997d..e9c2c3557 100644
--- a/compiler-rt/lib/asan/asan_fake_stack.cpp
+++ b/compiler-rt/lib/asan/asan_fake_stack.cpp
@@ -217,7 +217,7 @@ static THREADLOCAL FakeStack *fake_stack_tls;
 FakeStack *GetTLSFakeStack() {
   return fake_stack_tls;
 }
-void SetTLSFakeStack(AsanThread* t, FakeStack *fs) {
+void SetTLSFakeStack(AsanThread* t, FakeStack* fs) {
   if (fs && !t->fake_stack_usage_enabled()) {
     return;
   }
@@ -225,7 +225,7 @@ void SetTLSFakeStack(AsanThread* t, FakeStack *fs) {
 }
 #else
 FakeStack *GetTLSFakeStack() { return 0; }
-void SetTLSFakeStack(AsanThread* t, FakeStack *fs) { }
+void SetTLSFakeStack(AsanThread* t, FakeStack* fs) {}
 #endif  // (SANITIZER_LINUX && !SANITIZER_ANDROID) || SANITIZER_FUCHSIA
 
 static void DisableFakeStackUsage() {
@@ -237,19 +237,20 @@ static void DisableFakeStackUsage() {
 }
 
 static void EnableFakeStackUsage() {
-  AsanThread *t = GetCurrentThread();
+  AsanThread* t = GetCurrentThread();
   if (t) {
     t->set_fake_stack_usage_enabled(true);
   }
 }
 
-static FakeStack *GetFakeStack(bool for_allocation = true) {
-  AsanThread *t = GetCurrentThread();
-  if (!t || (for_allocation && !t->fake_stack_usage_enabled())) return nullptr;
+static FakeStack* GetFakeStack(bool for_allocation = true) {
+  AsanThread* t = GetCurrentThread();
+  if (!t || (for_allocation && !t->fake_stack_usage_enabled()))
+    return nullptr;
   return t->get_or_create_fake_stack();
 }
 
-static FakeStack *GetFakeStackFast(bool for_allocation = true) {
+static FakeStack* GetFakeStackFast(bool for_allocation = true) {
   if (FakeStack *fs = GetTLSFakeStack())
     return fs;
   if (!__asan_option_detect_stack_use_after_return)
@@ -329,7 +330,9 @@ extern "C" {
 // -asan-use-after-return=never, after modal UAR flag lands
 // (https://github.com/google/sanitizers/issues/1394)
 SANITIZER_INTERFACE_ATTRIBUTE
-void *__asan_get_current_fake_stack() { return GetFakeStackFast(/*for_allocation=*/false); }
+void* __asan_get_current_fake_stack() {
+  return GetFakeStackFast(/*for_allocation=*/false);
+}
 
 SANITIZER_INTERFACE_ATTRIBUTE
 void *__asan_addr_is_in_fake_stack(void *fake_stack, void *addr, void **beg,
diff --git a/compiler-rt/lib/asan/asan_fake_stack.h b/compiler-rt/lib/asan/asan_fake_stack.h
index 9f1f45283..1399ef138 100644
--- a/compiler-rt/lib/asan/asan_fake_stack.h
+++ b/compiler-rt/lib/asan/asan_fake_stack.h
@@ -198,7 +198,7 @@ class FakeStack {
 };
 
 FakeStack *GetTLSFakeStack();
-void SetTLSFakeStack(AsanThread* t, FakeStack *fs);
+void SetTLSFakeStack(AsanThread* t, FakeStack* fs);
 
 }  // namespace __asan
 
diff --git a/compiler-rt/test/asan/TestCases/disable_fake_stack.cpp b/compiler-rt/test/asan/TestCases/disable_fake_stack.cpp
index b1ee8d72e..f198df44d 100644
--- a/compiler-rt/test/asan/TestCases/disable_fake_stack.cpp
+++ b/compiler-rt/test/asan/TestCases/disable_fake_stack.cpp
@@ -8,8 +8,9 @@ volatile char *saved;
 
 ATTRIBUTE_NOINLINE bool IsOnStack() {
   volatile char temp = ' ';
-  void* fake_stack = __asan_get_current_fake_stack();
-  void* real = __asan_addr_is_in_fake_stack(fake_stack, const_cast<char*>(&temp), nullptr, nullptr);
+  void *fake_stack = __asan_get_current_fake_stack();
+  void *real = __asan_addr_is_in_fake_stack(
+      fake_stack, const_cast<char *>(&temp), nullptr, nullptr);
   saved = &temp;
   return real == nullptr;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/160135