[llvm] 6e977aa - [gn] port a513b701752b1

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 19 11:21:39 PDT 2025


Author: Nico Weber
Date: 2025-09-19T14:21:30-04:00
New Revision: 6e977aabb9494ab0afbe4b4b47465a0798e2bf45

URL: https://github.com/llvm/llvm-project/commit/6e977aabb9494ab0afbe4b4b47465a0798e2bf45
DIFF: https://github.com/llvm/llvm-project/commit/6e977aabb9494ab0afbe4b4b47465a0798e2bf45.diff

LOG: [gn] port a513b701752b1

Added: 
    

Modified: 
    llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
    llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn

Removed: 
    


################################################################################
diff  --git a/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn b/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
index 16065377ec919..1a2f954e37954 100644
--- a/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
@@ -18,8 +18,7 @@ write_cmake_config("clang-tidy-config") {
     values += [ "CLANG_TIDY_ENABLE_STATIC_ANALYZER=" ]
   }
 
-  # FIXME: Add a setting? Tests seem to fail when it's not set though:
-  # https://github.com/llvm/llvm-project/pull/131804#issuecomment-3312465207
+  # FIXME: Add option for this?
   values += [ "CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS=1" ]
 
   # Let targets depending on this find the generated file.

diff  --git a/llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn b/llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn
index 4f9ba335859bf..0057588c7aae6 100644
--- a/llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang-tools-extra/test/BUILD.gn
@@ -46,6 +46,9 @@ write_lit_config("lit_site_cfg") {
     extra_values += [ "CLANG_TIDY_ENABLE_STATIC_ANALYZER=0" ]
   }
 
+  # FIXME: Add option for this?
+  extra_values += [ "CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS=1" ]
+
   if (host_os == "mac") {
     extra_values += [ "LLVM_PLUGIN_EXT=.dylib" ]
   } else if (host_os == "win") {


        


More information about the llvm-commits mailing list