[llvm] [llvm][ELF]Add Shdr check for getBuildID (PR #126537)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 19 03:27:48 PDT 2025
jh7370 wrote:
> What would be the best approach for the test? Should I add a new test case to llvm/test/tools/llvm-objdump/ELF/program-headers.test, or is it better to modify an existing one?
I literally just said don't add a new lit test. You have an existing set of unit tests that you're adding in this patch. You could either add duplicates of them, or probably better, change them to test the edge values, instead of `FileSize: 0xffffffffffffffff` and `ShOffset: 0x8000` (I don't not know what exactly those values should be, but they should be the value at which point it goes from a "valid" value to an "invalid" value).
https://github.com/llvm/llvm-project/pull/126537
More information about the llvm-commits
mailing list