[llvm] [llvm][ELF]Add Shdr check for getBuildID (PR #126537)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 19 03:00:52 PDT 2025


jh7370 wrote:

A boundary condition is checking that comparison is checking the right value and prevents off-by-one style errors (e.g. it shows that `>` is used instead of `>=` or similar, by failing when the value is exactly one bigger/smaller than it needs to be for the check to pass). I explained this in https://github.com/llvm/llvm-project/pull/126537#discussion_r1975023265.

We don't need to add a lit test, as previously discussed in the review.


https://github.com/llvm/llvm-project/pull/126537


More information about the llvm-commits mailing list