[llvm] [Offload] Don't add the unsupported host plugin to the list (PR #159642)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 18 13:06:26 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-offload
Author: Joseph Huber (jhuber6)
<details>
<summary>Changes</summary>
Summary:
The host plugin is basically OpenMP specific and doesn't work very well.
Previously we were skipping over it in the list instead of just not
adding it at all.
---
Full diff: https://github.com/llvm/llvm-project/pull/159642.diff
1 Files Affected:
- (modified) offload/liboffload/src/OffloadImpl.cpp (+4-6)
``````````diff
diff --git a/offload/liboffload/src/OffloadImpl.cpp b/offload/liboffload/src/OffloadImpl.cpp
index b5b9b0e83b975..bf220779180c5 100644
--- a/offload/liboffload/src/OffloadImpl.cpp
+++ b/offload/liboffload/src/OffloadImpl.cpp
@@ -244,17 +244,15 @@ Error initPlugins(OffloadContext &Context) {
// Attempt to create an instance of each supported plugin.
#define PLUGIN_TARGET(Name) \
do { \
- Context.Platforms.emplace_back(ol_platform_impl_t{ \
- std::unique_ptr<GenericPluginTy>(createPlugin_##Name()), \
- pluginNameToBackend(#Name)}); \
+ if (StringRef(#Name) != "host") \
+ Context.Platforms.emplace_back(ol_platform_impl_t{ \
+ std::unique_ptr<GenericPluginTy>(createPlugin_##Name()), \
+ pluginNameToBackend(#Name)}); \
} while (false);
#include "Shared/Targets.def"
// Preemptively initialize all devices in the plugin
for (auto &Platform : Context.Platforms) {
- // Do not use the host plugin - it isn't supported.
- if (Platform.BackendType == OL_PLATFORM_BACKEND_UNKNOWN)
- continue;
auto Err = Platform.Plugin->init();
[[maybe_unused]] std::string InfoMsg = toString(std::move(Err));
for (auto DevNum = 0; DevNum < Platform.Plugin->number_of_devices();
``````````
</details>
https://github.com/llvm/llvm-project/pull/159642
More information about the llvm-commits
mailing list