[llvm] ab00172 - [ADT] Simplify isEqualImpl in DenseMapInfo.h (NFC) (#159508)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-09-18T08:55:25-07:00
New Revision: ab00172e2c5d799bbe9daff4347e1319b82400ed

URL: https://github.com/llvm/llvm-project/commit/ab00172e2c5d799bbe9daff4347e1319b82400ed
DIFF: https://github.com/llvm/llvm-project/commit/ab00172e2c5d799bbe9daff4347e1319b82400ed.diff

LOG: [ADT] Simplify isEqualImpl in DenseMapInfo.h (NFC) (#159508)

This patch replaces the recursive implementation of isEqualImpl with a
C++17 fold expression.

Added: 
    

Modified: 
    llvm/include/llvm/ADT/DenseMapInfo.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ADT/DenseMapInfo.h b/llvm/include/llvm/ADT/DenseMapInfo.h
index b91a908d992f8..57a8674e35015 100644
--- a/llvm/include/llvm/ADT/DenseMapInfo.h
+++ b/llvm/include/llvm/ADT/DenseMapInfo.h
@@ -194,20 +194,16 @@ template <typename... Ts> struct DenseMapInfo<std::tuple<Ts...>> {
     return getHashValueImpl<0>(values);
   }
 
-  template <unsigned I>
-  static bool isEqualImpl(const Tuple &lhs, const Tuple &rhs) {
-    if constexpr (I == sizeof...(Ts)) {
-      return true;
-    } else {
-      using EltType = std::tuple_element_t<I, Tuple>;
-      return DenseMapInfo<EltType>::isEqual(std::get<I>(lhs),
-                                            std::get<I>(rhs)) &&
-             isEqualImpl<I + 1>(lhs, rhs);
-    }
+  template <std::size_t... Is>
+  static bool isEqualImpl(const Tuple &lhs, const Tuple &rhs,
+                          std::index_sequence<Is...>) {
+    return (DenseMapInfo<std::tuple_element_t<Is, Tuple>>::isEqual(
+                std::get<Is>(lhs), std::get<Is>(rhs)) &&
+            ...);
   }
 
   static bool isEqual(const Tuple &lhs, const Tuple &rhs) {
-    return isEqualImpl<0>(lhs, rhs);
+    return isEqualImpl(lhs, rhs, std::index_sequence_for<Ts...>{});
   }
 };