[llvm] 5f8bce4 - [GlobalISel] Remove virtual from GISelValueTracking computeKnownBitsImpl. (#158558)

[via llvm-commits]

Author: David Green
Date: 2025-09-17T17:52:20+01:00
New Revision: 5f8bce4900b65b509ca1f9bf0a616409a77ced37

URL: https://github.com/llvm/llvm-project/commit/5f8bce4900b65b509ca1f9bf0a616409a77ced37
DIFF: https://github.com/llvm/llvm-project/commit/5f8bce4900b65b509ca1f9bf0a616409a77ced37.diff

LOG: [GlobalISel] Remove virtual from GISelValueTracking computeKnownBitsImpl. (#158558)

As far as I understand, GISelValueTracking::computeKnownBitsImpl does
not need to be virtual, as no-one is specializing / overriding it, which
means it is not necessary for the destructor either.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h b/llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h
index 3bf9d694b1b21..2db66ba9584a3 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h
@@ -58,15 +58,14 @@ class LLVM_ABI GISelValueTracking : public GISelChangeObserver {
 
 public:
   GISelValueTracking(MachineFunction &MF, unsigned MaxDepth = 6);
-  virtual ~GISelValueTracking() = default;
+  ~GISelValueTracking() = default;
 
   const MachineFunction &getMachineFunction() const { return MF; }
 
   const DataLayout &getDataLayout() const { return DL; }
 
-  virtual void computeKnownBitsImpl(Register R, KnownBits &Known,
-                                    const APInt &DemandedElts,
-                                    unsigned Depth = 0);
+  void computeKnownBitsImpl(Register R, KnownBits &Known,
+                            const APInt &DemandedElts, unsigned Depth = 0);
 
   unsigned computeNumSignBits(Register R, const APInt &DemandedElts,
                               unsigned Depth = 0);