[llvm] [ARM] Call isSchedulingBoundary instead of doing the check manually (NFC) (PR #159393)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 17 09:36:58 PDT 2025
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/159393
>From ae2194dda1a93a48a9bcb959a9ac2f95f366ecd5 Mon Sep 17 00:00:00 2001
From: AZero13 <gfunni234 at gmail.com>
Date: Wed, 17 Sep 2025 12:22:32 -0400
Subject: [PATCH] [ARM] Call isSchedulingBoundary instead of doing the check
manually (NFC)
---
llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp | 23 ++---------------------
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
index 5c35b3327c16d..910ce8d1e2a6a 100644
--- a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
+++ b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
@@ -1897,12 +1897,7 @@ bool ARMBaseInstrInfo::isSchedulingBoundary(const MachineInstr &MI,
if (MI.isDebugInstr())
return false;
- // Terminators and labels can't be scheduled around.
- if (MI.isTerminator() || MI.isPosition())
- return true;
-
- // INLINEASM_BR can jump to another block
- if (MI.getOpcode() == TargetOpcode::INLINEASM_BR)
+ if (TargetInstrInfo::isSchedulingBoundary(MI, MBB, MF))
return true;
if (isSEHInstruction(MI))
@@ -1918,21 +1913,7 @@ bool ARMBaseInstrInfo::isSchedulingBoundary(const MachineInstr &MI,
// Make sure to skip any debug instructions
while (++I != MBB->end() && I->isDebugInstr())
;
- if (I != MBB->end() && I->getOpcode() == ARM::t2IT)
- return true;
-
- // Don't attempt to schedule around any instruction that defines
- // a stack-oriented pointer, as it's unlikely to be profitable. This
- // saves compile time, because it doesn't require every single
- // stack slot reference to depend on the instruction that does the
- // modification.
- // Calls don't actually change the stack pointer, even if they have imp-defs.
- // No ARM calling conventions change the stack pointer. (X86 calling
- // conventions sometimes do).
- if (!MI.isCall() && MI.definesRegister(ARM::SP, /*TRI=*/nullptr))
- return true;
-
- return false;
+ return (I != MBB->end() && I->getOpcode() == ARM::t2IT);
}
bool ARMBaseInstrInfo::
More information about the llvm-commits
mailing list