[llvm] [UpdateTestChecks] Don't fail silently when conflicting CHECK lines means no checks are generated for some functions (PR #159321)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 17 04:09:07 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r origin/main...HEAD llvm/utils/UpdateTestChecks/common.py
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- common.py 2025-09-17 10:58:39.000000 +0000
+++ common.py 2025-09-17 11:08:41.543590 +0000
@@ -953,17 +953,16 @@
for func, warning_info in warnings_to_print.items():
conflict_strs = []
for run_index, prefixes in warning_info:
conflict_strs.append(
- "RUN #{} (prefixes: {})".format(
- run_index + 1, ", ".join(prefixes)
- )
+ "RUN #{} (prefixes: {})".format(run_index + 1, ", ".join(prefixes))
)
warn(
"For function '{}', the following RUN lines will not generate checks due to conflicting output: {}".format(
- func, ", ".join(conflict_strs)),
+ func, ", ".join(conflict_strs)
+ ),
test_file=self._path,
)
return self._func_dict
``````````
</details>
https://github.com/llvm/llvm-project/pull/159321
More information about the llvm-commits
mailing list