[llvm] [DecoderEmitter] Eliminate `DecodeComplete` parameter to `decodeToMCInst` (PR #159130)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 16 11:43:13 PDT 2025


s-barannikov wrote:

> Note, when there is any incomplete decode, we always generate TryDecode and never generate a Decode. So when hasIncompleteDecoder = true, its always TryDecode and there is no need to consider Decode AFAICT.

Right, but this doesn't make the description less confusing. The statement

> Currently, the code generated by decoder emitter always set `DeocdeComplete` to false when returning Fail from `decodeToMCInst`.

is basically not true. There is a path that doesn't set `DecodeComplete` to false when returning Fail, and this happens in 99% cases.


https://github.com/llvm/llvm-project/pull/159130


More information about the llvm-commits mailing list