[llvm] [Remarks] BitstreamRemarkParser: Refactor error handling (PR #156511)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 15 09:20:46 PDT 2025


llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu` running on `as-builder-7` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/25021

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
22914 |       }, TT.isWatchABI() ? DefaultCC :
      |          ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
22915 |     (isAAPCS_ABI(TT, ABIName) ? CallingConv::ARM_AAPCS : CallingConv::ARM_APCS));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/include/llvm/IR/RuntimeLibcalls.inc:22924:26: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
22924 |       }, TT.isWatchABI() ? DefaultCC :
      |          ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
22925 |     (isAAPCS_ABI(TT, ABIName) ? CallingConv::ARM_AAPCS : CallingConv::ARM_APCS));
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
36.087 [1795/128/898] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/lib/Remarks -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/include -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
36.088 [1795/127/899] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/lib/Remarks -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/build/include -I/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/RemarkParser.cpp
In file included from /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/RemarkParser.cpp:15:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
36.177 [1795/20/1006] Building CXX object lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/LegalizerHelper.cpp.o
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp: In member function ‘llvm::Register llvm::LegalizerHelper::buildVariableShiftPart(unsigned int, llvm::Register, llvm::Register, llvm::LLT, llvm::Register)’:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:6229:40: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
 6229 |       (Opcode == TargetOpcode::G_ASHR) ? TargetOpcode::G_LSHR : Opcode;
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
36.189 [1795/3/1023] Building CXX object lib/CodeGen/SelectionDAG/CMakeFiles/LLVMSelectionDAG.dir/SelectionDAG.cpp.o
In file included from /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:13:
In constructor ‘llvm::SelectionDAG::DAGUpdateListener::DAGUpdateListener(llvm::SelectionDAG&)’,
    inlined from ‘{anonymous}::RAUWUpdateListener::RAUWUpdateListener(llvm::SelectionDAG&, llvm::SDNode::use_iterator&, llvm::SDNode::use_iterator&)’ at /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:12105:56,
    inlined from ‘void llvm::SelectionDAG::ReplaceAllUsesWith(llvm::SDNode*, llvm::SDNode*)’ at /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:12192:44:
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:324:27: warning: storing the address of local variable ‘Listener’ in ‘*this.llvm::SelectionDAG::UpdateListeners’ [-Wdangling-pointer=]
  324 |       DAG.UpdateListeners = this;
      |       ~~~~~~~~~~~~~~~~~~~~^~~~~~
/home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp: In member function ‘void llvm::SelectionDAG::ReplaceAllUsesWith(llvm::SDNode*, llvm::SDNode*)’:

```

</details>

https://github.com/llvm/llvm-project/pull/156511


More information about the llvm-commits mailing list