[llvm] [Remarks] BitstreamRemarkParser: Refactor error handling (PR #156511)

Mon Sep 15 07:32:22 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lld-x86_64-ubuntu-fast` running on `as-builder-4` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/23034

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
3.491 [3493/64/496] Building ARMGenMCPseudoLowering.inc...
3.525 [3492/64/497] Building R600GenDAGISel.inc...
3.548 [3491/64/498] Building ARMGenRegisterInfo.inc...
3.578 [3490/64/499] Building ARMGenCallingConv.inc...
3.591 [3489/64/500] Building ARMGenSystemRegister.inc...
3.594 [3488/64/501] Building ARMGenMCCodeEmitter.inc...
3.646 [3487/64/502] Building ARMGenRegisterBank.inc...
3.688 [3486/64/503] Building R600GenInstrInfo.inc...
3.695 [3485/64/504] Building ARMGenDisassemblerTables.inc...
3.696 [3484/64/505] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/lib/Remarks -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/RemarkParser.cpp
In file included from /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/RemarkParser.cpp:15:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
3.713 [3484/63/506] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/lib/Remarks -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
3.757 [3484/62/507] Building ARMGenAsmWriter.inc...
3.772 [3484/61/508] Building ARMGenAsmMatcher.inc...
3.878 [3484/60/509] Building AVRGenCallingConv.inc...
4.008 [3484/59/510] Building AArch64GenExegesis.inc...
4.014 [3484/58/511] Building AVRGenDisassemblerTables.inc...
4.022 [3484/57/512] Building AVRGenSDNodeInfo.inc...
4.036 [3484/56/513] Building AArch64GenMCPseudoLowering.inc...
4.093 [3484/55/514] Building AArch64GenSDNodeInfo.inc...
4.095 [3484/54/515] Building AVRGenMCCodeEmitter.inc...
4.103 [3484/53/516] Building AArch64GenPreLegalizeGICombiner.inc...
4.130 [3484/52/517] Building AVRGenDAGISel.inc...
4.168 [3484/51/518] Building AVRGenRegisterInfo.inc...
4.171 [3484/50/519] Building AArch64GenO0PreLegalizeGICombiner.inc...
4.194 [3484/49/520] Building AArch64GenPostLegalizeGICombiner.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/156511