[llvm] [Remarks] BitstreamRemarkParser: Refactor error handling (PR #156511)

Mon Sep 15 07:30:14 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/22044

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[1101/8067] Building R600GenCallingConv.inc...
[1102/8067] Building SPIRVGenAsmWriter.inc...
[1103/8067] Building R600GenRegisterInfo.inc...
[1104/8067] Building SPIRVGenRegisterBank.inc...
[1105/8067] Building SPIRVGenPreLegalizeGICombiner.inc...
[1106/8067] Building SPIRVGenInstrInfo.inc...
[1107/8067] Building SPIRVGenRegisterInfo.inc...
[1108/8067] Building R600GenInstrInfo.inc...
[1109/8067] Building R600GenSubtargetInfo.inc...
[1110/8067] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
[1111/8067] Building SPIRVGenTables.inc...
[1112/8067] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/RemarkParser.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/RemarkParser.cpp:15:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
[1113/8067] Building SPIRVGenSubtargetInfo.inc...
[1114/8067] Building CXX object tools/flang/lib/Decimal/CMakeFiles/FortranDecimal.dir/binary-to-decimal.cpp.o
[1115/8067] Building RISCVTargetParserDef.inc...
[1116/8067] Building X86GenExegesis.inc...
[1117/8067] Building X86GenAsmWriter1.inc...
[1118/8067] Building X86GenAsmMatcher.inc...
[1119/8067] Building X86GenInstrMapping.inc...
[1120/8067] Building X86GenFoldTables.inc...
[1121/8067] Building X86GenCallingConv.inc...
[1122/8067] Building X86GenAsmWriter.inc...
[1123/8067] Building X86GenDisassemblerTables.inc...
[1124/8067] Building X86GenFastISel.inc...
[1125/8067] Building X86GenGlobalISel.inc...
[1126/8067] Building X86GenDAGISel.inc...
[1127/8067] Building X86GenInstrInfo.inc...
Step 7 (build cmake config) failure: build cmake config (failure)
...
[1101/8067] Building R600GenCallingConv.inc...
[1102/8067] Building SPIRVGenAsmWriter.inc...
[1103/8067] Building R600GenRegisterInfo.inc...
[1104/8067] Building SPIRVGenRegisterBank.inc...
[1105/8067] Building SPIRVGenPreLegalizeGICombiner.inc...
[1106/8067] Building SPIRVGenInstrInfo.inc...
[1107/8067] Building SPIRVGenRegisterInfo.inc...
[1108/8067] Building R600GenInstrInfo.inc...
[1109/8067] Building R600GenSubtargetInfo.inc...
[1110/8067] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
[1111/8067] Building SPIRVGenTables.inc...
[1112/8067] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/RemarkParser.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/RemarkParser.cpp:15:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
[1113/8067] Building SPIRVGenSubtargetInfo.inc...
[1114/8067] Building CXX object tools/flang/lib/Decimal/CMakeFiles/FortranDecimal.dir/binary-to-decimal.cpp.o
[1115/8067] Building RISCVTargetParserDef.inc...
[1116/8067] Building X86GenExegesis.inc...
[1117/8067] Building X86GenAsmWriter1.inc...
[1118/8067] Building X86GenAsmMatcher.inc...
[1119/8067] Building X86GenInstrMapping.inc...
[1120/8067] Building X86GenFoldTables.inc...
[1121/8067] Building X86GenCallingConv.inc...
[1122/8067] Building X86GenAsmWriter.inc...
[1123/8067] Building X86GenDisassemblerTables.inc...
[1124/8067] Building X86GenFastISel.inc...
[1125/8067] Building X86GenGlobalISel.inc...
[1126/8067] Building X86GenDAGISel.inc...
[1127/8067] Building X86GenInstrInfo.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/156511