[llvm] [Remarks] BitstreamRemarkParser: Refactor error handling (PR #156511)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 15 07:25:14 PDT 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-nvidia-gcc7` running on `mlir-nvidia` while building `llvm` at step 6 "build-check-mlir-build-only".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/18343

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-check-mlir-build-only) failure: build (failure)
...
2.893 [4172/16/782] Building GPUOpsDialect.h.inc...
2.900 [4171/16/783] Building GPUTransformOps.cpp.inc...
2.930 [4170/16/784] Building GPUOps.cpp.inc...
2.935 [4169/16/785] Building GPUOps.h.inc...
3.054 [4168/16/786] Building ARMTargetParserDef.inc...
3.697 [4167/16/787] Building AArch64TargetParserDef.inc...
4.279 [4166/16/788] Building NVPTXGenRegisterInfo.inc...
4.465 [4165/16/789] Building NVPTXGenAsmWriter.inc...
4.493 [4164/16/790] Building NVPTXGenSubtargetInfo.inc...
5.158 [4163/16/791] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/g++-7 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/lib/Remarks -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/include -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/RemarkParser.cpp
In file included from /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/RemarkParser.cpp:15:0:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
5.192 [4163/15/792] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/g++-7 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/lib/Remarks -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/include -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:0:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:73:66: error: no matching function for call to ‘llvm::remarks::BitstreamBlockParserHelper<Derived>::unexpectedRecord(unsigned int&)’
   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
                                                                  ^
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note: candidate: llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)
   Error unexpectedRecord(StringRef RecordName);
         ^~~~~~~~~~~~~~~~
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:9: note:   no known conversion for argument 1 from ‘unsigned int’ to ‘llvm::StringRef’
5.424 [4163/14/793] Building NVPTXGenDAGISel.inc...
5.738 [4163/13/794] Building NVPTXGenInstrInfo.inc...
6.390 [4163/12/795] Building X86GenCallingConv.inc...
6.551 [4163/11/796] Building RISCVTargetParserDef.inc...
6.604 [4163/10/797] Building X86GenExegesis.inc...
6.645 [4163/9/798] Building X86GenAsmWriter1.inc...
6.799 [4163/8/799] Building X86GenAsmWriter.inc...
7.529 [4163/7/800] Building X86GenAsmMatcher.inc...
7.569 [4163/6/801] Building X86GenDisassemblerTables.inc...
7.887 [4163/5/802] Building X86GenFoldTables.inc...
9.884 [4163/4/803] Building X86GenFastISel.inc...
10.954 [4163/3/804] Building X86GenGlobalISel.inc...
11.181 [4163/2/805] Building X86GenDAGISel.inc...
14.304 [4163/1/806] Building X86GenInstrInfo.inc...
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/156511

More information about the llvm-commits mailing list